Replaces "Search" title in tab bar with magnifying glass icon only on iPad with OS version 18 and above #5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iPad with OS version 18 and above
tonisevener
requested changes
Feb 20, 2025
There was a problem hiding this comment.
@chandra9302 Thanks for the PR! Code looks good to me so far. I will put this through design review.
I did find a couple of bugs when clicking around:
-
Automatic theming. On iPadOS 18, in app Settings choose "Default" theme. Background, in iOS settings switch light or dark appearance mode. When you return the content does not auto-theme:
-
When in split screen mode, the bottom tab bar loses its icons, and when I tap one I see a crash:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
T383831
Notes
Test Steps
Screenshots/Videos