Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the issue of navigation bar hiding on tab switch resulting in content visiblity under navigatoin bar in Search tab. #5198

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Fixes the issue of navigation bar hiding on tab switch resulting in content visiblity under navigatoin bar in Search tab. #5198

merged 3 commits into from
Feb 19, 2025

Conversation

chandra9302
Copy link
Contributor

Phabricator:
T385077

Notes

  • The issue arises when viewing search results in the Search tab, switching to another tab, returning to the Search tab, and then scrolling through the search results. During this process, the navigation bar scrolls along with the search results.

Test Steps

  • Add more than 1 language in the App
  • Open Search Tab
  • Search results by typing in bar and choosing blue "Search" button on keyboard
  • Navigate to another root view like Saved
  • Go back to Search Tab and start scrolling on results

Screenshots/Videos

Before Fix:
Bug3

After Fix:
Fix3

@chandra9302
Fixes the issue of navigation bar hiding on tab switch resulting in c…
e30d9f5 
…ontent visiblity under navigatoin bar in Search tab.
@mazevedofs
Copy link
Collaborator

Adding the Phab task link https://phabricator.wikimedia.org/T386274

@tonisevener tonisevener added 7.7.2 and removed 7.7.2 labels Feb 19, 2025
@tonisevener tonisevener merged commit 30681a6 into wikimedia:main Feb 19, 2025
1 check failed
@chandra9302 chandra9302 deleted the T386274 branch February 20, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
7.7.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandra9302 @mazevedofs @tonisevener