Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to test PR version against app version #5197

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

tonisevener
Copy link
Collaborator

@tonisevener tonisevener commented Feb 12, 2025

Phabricator: N/A

Notes

Per discussions, this PR creates a GitHub Actions workflow that checks the current app version in Info.plist against the PR labels. If the PR label does not match the current app version, the script fails.

This is to hopefully prevent merging PRs that aren't ready yet into main.

Test Steps

  1. Remove the 7.7.2 label on this PR, observe that check fails.
  2. Bring 7.7.2 label back, observe that check succeeds.

@tonisevener tonisevener marked this pull request as draft February 12, 2025 23:14
@tonisevener tonisevener added the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Feb 13, 2025
@tonisevener tonisevener reopened this Feb 13, 2025
@tonisevener tonisevener added 7.7.2 and removed 7.7.2 labels Feb 13, 2025
@tonisevener tonisevener added 7.7.2 and removed 7.7.2 Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging labels Feb 13, 2025
@tonisevener tonisevener changed the title [Draft] Temp PR to test version workflow Add workflow to test PR version against app version Feb 13, 2025
@tonisevener tonisevener marked this pull request as ready for review February 13, 2025 02:07
@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team February 13, 2025 14:19
@mazevedofs mazevedofs added 7.7.2 and removed 7.7.2 labels Feb 14, 2025
@tonisevener tonisevener merged commit 5f4f310 into main Feb 14, 2025
4 checks passed
@tonisevener tonisevener deleted the temp-PR branch February 14, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants