Skip to content

Commit

Permalink
String changes from building, fix warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
tonisevener committed Feb 24, 2025
1 parent 43e715a commit 1200cfa
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ public final class WMFNavigationExperimentsDataController {
assignment = ArticleSearchBarExperimentAssignment.test
case .articleSearchBarControl:
assignment = ArticleSearchBarExperimentAssignment.control
default:
throw CustomError.unexpectedAssignment
}

self.assignmentCache = assignment
Expand Down Expand Up @@ -84,8 +82,6 @@ public final class WMFNavigationExperimentsDataController {
assignment = ArticleSearchBarExperimentAssignment.test
case .articleSearchBarControl:
assignment = ArticleSearchBarExperimentAssignment.control
default:
throw CustomError.unexpectedAssignment
}

self.assignmentCache = assignment
Expand Down
1 change: 0 additions & 1 deletion Wikipedia/Code/UIViewController+ProfileButton.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ extension UIViewController {
hasUnreadNotifications = true
}

let accessibilityLabel = hasUnreadNotifications ? CommonStrings.profileButtonBadgeTitle : CommonStrings.profileButtonTitle
let accessibilityHint = CommonStrings.profileButtonAccessibilityHint

return WMFNavigationBarProfileButtonConfig(accessibilityLabelNoNotifications: CommonStrings.profileButtonTitle, accessibilityLabelHasNotifications: CommonStrings.profileButtonBadgeTitle, accessibilityHint: accessibilityHint, needsBadge: hasUnreadNotifications, target: target, action: action, leadingBarButtonItem: leadingBarButtonItem, trailingBarButtonItem: trailingBarButtonItem)
Expand Down
Binary file modified Wikipedia/iOS Native Localizations/es.lproj/Localizable.strings
Binary file not shown.
Binary file modified Wikipedia/iOS Native Localizations/it.lproj/Localizable.strings
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified Wikipedia/iOS Native Localizations/sk.lproj/Localizable.strings
Binary file not shown.
Binary file modified Wikipedia/iOS Native Localizations/tr.lproj/Localizable.strings
Binary file not shown.

0 comments on commit 1200cfa

Please sign in to comment.