Merge pull request #3 from well-known-components/fix/add-live-request

fix: Prevent the live and ready requests from being printed
well-known-components · Mar 8, 2023 · 256d1c8 · 256d1c8
2 parents c4e07c3 + 2a9d235
commit 256d1c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/component.ts b/src/component.ts
@@ -1,5 +1,5 @@
 import { IHttpServerComponent, ILoggerComponent } from '@well-known-components/interfaces'
-import { HEALTH_PATH } from './constants'
+import { HEALTH_LIVE, HEALTH_READY } from './constants'
 import { shouldSkip } from './logic'
 import { RequestLoggerConfigurations, Verbosity } from './types'
 
@@ -19,7 +19,7 @@ export function instrumentHttpServerWithRequestLogger(
     const skipInput = config?.skipInput
     const skipOutput = config?.skipOutput
     // Skip health checks by default
-    const skip = shouldSkip(ctx, config?.skip ?? HEALTH_PATH)
+    const skip = shouldSkip(ctx, config?.skip ?? [HEALTH_LIVE, HEALTH_READY])
 
     const inLog = config?.inputLog ? config.inputLog(ctx.request) : `[${ctx.request.method}: ${ctx.url.pathname}]`
     if (!skipInput && !skip) {

diff --git a/src/constants.ts b/src/constants.ts
@@ -1 +1,2 @@
-export const HEALTH_PATH = '/health/live'
+export const HEALTH_LIVE = '/health/live'
+export const HEALTH_READY = '/health/ready'