Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump internal media core version #4128

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

edvujic
Copy link
Contributor

@edvujic edvujic commented Mar 3, 2025

COMPLETES SPARK-623552

After 291 we have observed a significant amount of validation errors related to concealedFrames. This issue was caused because we were assigning the clockRate only to audio-recv, whereas we should also assign it to audio-share-recv. This oversight led to a division by undefined in the calculateAudioReceiverConcealedFrames function.

This was fixed by https://sqbu-github.cisco.com/WebExSquared/webrtc-media-core/commit/6cfad321821bc30f98772a5845aac592fbdb5860

625b41aa-2106-4031-a6db-3124bc092b2a correlationID before fix
571a1348-46c2-4808-80cb-0c178dc43689 correlationID after fix

by making the following changes

Need to update the internal-media-core version to reflect the changes.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@edvujic edvujic requested review from a team as code owners March 3, 2025 14:13
@edvujic edvujic self-assigned this Mar 3, 2025
Copy link

coderabbitai bot commented Mar 3, 2025

📝 Walkthrough

Walkthrough

This pull request updates the version of the @webex/internal-media-core dependency across three packages in the repository. In the packages @webex/media-helpers, @webex/plugin-meetings, and @webex/calling, the dependency version is changed from 2.14.0 to 2.14.2. The update is consistently applied in each package’s package.json file, ensuring that the internal media core library is updated uniformly across these modules. No other modifications to dependencies or scripts are included in these changes.

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b1d301 and b98242b.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • packages/@webex/media-helpers/package.json (1 hunks)
  • packages/@webex/plugin-meetings/package.json (1 hunks)
  • packages/calling/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Initialize Project
  • GitHub Check: AWS Amplify Console Web Preview
🔇 Additional comments (3)
packages/calling/package.json (1)

40-40: Dependency Version Update Verification

The internal media core dependency has been updated to "2.14.2" as required by the PR objectives. This update should address the underlying issue with the calculateAudioReceiverConcealedFrames function that was linked to an incorrect clockRate assignment. Please confirm that all tests and integration flows have been validated with this new version.

packages/@webex/media-helpers/package.json (1)

25-25: Consistent Dependency Update

The update for @webex/internal-media-core to "2.14.2" is correctly applied in this package, ensuring consistency with other parts of the codebase. This change aligns with the coordinated release version and should resolve the referenced issue.

packages/@webex/plugin-meetings/package.json (1)

66-66: Unified Dependency Version Update

The version of @webex/internal-media-core has been updated to "2.14.2", keeping this package in line with the other modules. Ensure that any functionality depending on this dependency has been retested to confirm that the bug fix is effective and no new issues are introduced.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@edvujic edvujic added the validated If the pull request is validated for automation. label Mar 3, 2025
# Conflicts:
#	packages/@webex/media-helpers/package.json
#	packages/@webex/plugin-meetings/package.json
#	packages/calling/package.json
#	yarn.lock
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4128.d3m3l2kee0btzx.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants