-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump internal media core version #4128
base: next
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis pull request updates the version of the Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
# Conflicts: # packages/@webex/media-helpers/package.json # packages/@webex/plugin-meetings/package.json # packages/calling/package.json # yarn.lock
This pull request is automatically being deployed by Amplify Hosting (learn more). |
COMPLETES SPARK-623552
After 291 we have observed a significant amount of validation errors related to
concealedFrames
. This issue was caused because we were assigning theclockRate
only toaudio-recv
, whereas we should also assign it toaudio-share-recv
. This oversight led to a division byundefined
in thecalculateAudioReceiverConcealedFrames
function.This was fixed by https://sqbu-github.cisco.com/WebExSquared/webrtc-media-core/commit/6cfad321821bc30f98772a5845aac592fbdb5860
625b41aa-2106-4031-a6db-3124bc092b2a
correlationID before fix571a1348-46c2-4808-80cb-0c178dc43689
correlationID after fixby making the following changes
Need to update the internal-media-core version to reflect the changes.
Change Type
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.