fi: disable turn tcp (#4096)

webex · Feb 12, 2025 · 39352b7 · 39352b7
1 parent e6c0ae8
commit 39352b7
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 26 deletions.
diff --git a/packages/@webex/plugin-meetings/src/media/index.ts b/packages/@webex/plugin-meetings/src/media/index.ts
@@ -163,17 +163,17 @@ Media.createMediaConnection = (
   // we might not have any TURN server if TURN discovery failed or wasn't done or
   // we might get an empty TURN url if we land on a video mesh node
   if (turnServerInfo?.url) {
-    if (!isBrowser('firefox')) {
-      let bareTurnServer = turnServerInfo.url;
-      bareTurnServer = bareTurnServer.replace('turns:', 'turn:');
-      bareTurnServer = bareTurnServer.replace('443', '5004');
-
-      iceServers.push({
-        urls: bareTurnServer,
-        username: turnServerInfo.username || '',
-        credential: turnServerInfo.password || '',
-      });
-    }
+    // if (!isBrowser('firefox')) {
+    //   let bareTurnServer = turnServerInfo.url;
+    //   bareTurnServer = bareTurnServer.replace('turns:', 'turn:');
+    //   bareTurnServer = bareTurnServer.replace('443', '5004');
+
+    //   iceServers.push({
+    //     urls: bareTurnServer,
+    //     username: turnServerInfo.username || '',
+    //     credential: turnServerInfo.password || '',
+    //   });
+    // }
 
     // TURN-TLS server
     iceServers.push({

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/media/index.ts b/packages/@webex/plugin-meetings/test/unit/spec/media/index.ts
@@ -90,11 +90,11 @@ describe('createMediaConnection', () => {
       roapMediaConnectionConstructorStub,
       {
         iceServers: [
-          {
-            urls: 'turn:turn-server-url:5004?transport=tcp',
-            username: 'turn username',
-            credential: 'turn password',
-          },
+          // {
+          //   urls: 'turn:turn-server-url:5004?transport=tcp',
+          //   username: 'turn username',
+          //   credential: 'turn password',
+          // },
           {
             urls: 'turns:turn-server-url:443?transport=tcp',
             username: 'turn username',
@@ -170,11 +170,11 @@ describe('createMediaConnection', () => {
       multistreamRoapMediaConnectionConstructorStub,
       {
         iceServers: [
-          {
-            urls: 'turn:turn-server-url:5004?transport=tcp',
-            username: 'turn username',
-            credential: 'turn password',
-          },
+          // {
+          //   urls: 'turn:turn-server-url:5004?transport=tcp',
+          //   username: 'turn username',
+          //   credential: 'turn password',
+          // },
           {
             urls: 'turns:turn-server-url:443?transport=tcp',
             username: 'turn username',

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js b/packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js
@@ -3772,11 +3772,11 @@ describe('plugin-meetings', () => {
             expectedDebugId = `MC-${meeting.id.substring(0, 4)}`;
             expectedMediaConnectionConfig = {
               iceServers: [
-                {
-                  urls: 'turn:turn-server-url:5004?transport=tcp',
-                  username: 'turn user',
-                  credential: 'turn password',
-                },
+                // {
+                //   urls: 'turn:turn-server-url:5004?transport=tcp',
+                //   username: 'turn user',
+                //   credential: 'turn password',
+                // },
                 {
                   urls: 'turns:turn-server-url:443?transport=tcp',
                   username: 'turn user',