Fix-Uts in-plugin-meetings (#3429)

Co-authored-by: Shreyas Sharma <shreysh2@cisco.com> Co-authored-by: Kesava Krishnan Madavan <kmadavan@cisco.com>
webex · Mar 20, 2024 · 13d3bf7 · 13d3bf7
1 parent 0924685
commit 13d3bf7
Show file tree

Hide file tree

Showing 13 changed files with 259 additions and 800 deletions.
diff --git a/packages/@webex/media-helpers/jest.config.js b/packages/@webex/media-helpers/jest.config.js
@@ -0,0 +1,6 @@
+const config = require('@webex/jest-config-legacy');
+
+module.exports = {
+  ...config,
+  testEnvironment: 'jsdom',
+};
diff --git a/packages/@webex/media-helpers/package.json b/packages/@webex/media-helpers/package.json
@@ -19,7 +19,7 @@
     "test:browser:broken": "webex-legacy-tools test --integration --unit --runner karma",
     "test:integration:broken": "webex-legacy-tools test --integration --runner mocha",
     "test:style": "eslint 'src/**/*.ts' --fix",
-    "test:unit:broken": "webex-legacy-tools test --unit --runner mocha",
+    "test:unit": "webex-legacy-tools test --unit --runner jest",
     "deploy:npm": "yarn npm publish"
   },
   "dependencies": {

diff --git a/packages/@webex/media-helpers/test/unit/spec/webrtc-core.js b/packages/@webex/media-helpers/test/unit/spec/webrtc-core.js
@@ -32,7 +32,6 @@ describe('media-helpers', () => {
         spyFn: 'createMicrophoneStream',
       },
     ];
-
     classesToTest.forEach(({className, title, event, createFn, spyFn}) =>
       describe(title, () => {
         const fakeStream = {
@@ -58,15 +57,15 @@ describe('media-helpers', () => {
         });
 
         it('rejects setMute(false) if unmute is not allowed', async () => {
-          stream.setUnmuteAllowed(false);
+          await stream.setUnmuteAllowed(false);
 
           assert.equal(stream.isUnmuteAllowed(), false);
           const fn = () => stream.setMuted(false);
           expect(fn).to.throw(/Unmute is not allowed/);
         });
 
         it('resolves setMute(false) if unmute is allowed', async () => {
-          stream.setUnmuteAllowed(true);
+          await stream.setUnmuteAllowed(true);
 
           assert.equal(stream.isUnmuteAllowed(), true);
           await stream.setMuted(false);
@@ -81,15 +80,15 @@ describe('media-helpers', () => {
             sinon.restore();
           });
 
-          const checkSetServerMuted = (startMute, setMute, expectedCalled) => {
-            stream.setMuted(startMute);
+          const checkSetServerMuted = async (startMute, setMute, expectedCalled) => {
+            await stream.setMuted(startMute);
 
             assert.equal(stream.muted, startMute);
 
             const handler = sinon.fake();
             stream.on(event.ServerMuted, handler);
 
-            stream.setServerMuted(setMute, 'remotelyMuted');
+            await stream.setServerMuted(setMute, 'remotelyMuted');
 
             assert.equal(stream.muted, setMute);
             if (expectedCalled) {
@@ -100,19 +99,19 @@ describe('media-helpers', () => {
           };
 
           it('tests true to false', async () => {
-            checkSetServerMuted(true, false, true);
+            await checkSetServerMuted(true, false, true);
           });
 
           it('tests false to true', async () => {
-            checkSetServerMuted(false, true, true);
+            await checkSetServerMuted(false, true, true);
           });
 
           it('tests true to true', async () => {
-            checkSetServerMuted(true, true, false);
+            await checkSetServerMuted(true, true, false);
           });
 
           it('tests false to false', async () => {
-            checkSetServerMuted(false, false, false);
+            await checkSetServerMuted(false, false, false);
           });
         });
 
@@ -121,7 +120,7 @@ describe('media-helpers', () => {
             const constraints = {deviceId: 'abc'};
 
             const spy = sinon.stub(wcmestreams, spyFn).returns('something');
-            const result = createFn(constraints);
+            const result = await createFn(constraints);
 
             assert.equal(result, 'something');
             assert.calledOnceWithExactly(spy, className, constraints);
@@ -133,7 +132,7 @@ describe('media-helpers', () => {
     describe('createDisplayStream', () => {
       it('checks createDisplayStream', async () => {
         const spy = sinon.stub(wcmestreams, 'createDisplayStream').returns('something');
-        const result = createDisplayStream();
+        const result = await createDisplayStream();
         assert.equal(result, 'something');
         assert.calledOnceWithExactly(spy, LocalDisplayStream);
       });
@@ -142,7 +141,7 @@ describe('media-helpers', () => {
     describe('createDisplayStreamWithAudio', () => {
       it('checks createDisplayStreamWithAudio', async () => {
         const spy = sinon.stub(wcmestreams, 'createDisplayStreamWithAudio').returns('something');
-        const result = createDisplayStreamWithAudio();
+        const result = await createDisplayStreamWithAudio();
         assert.equal(result, 'something');
         assert.calledOnceWithExactly(spy, LocalDisplayStream, LocalSystemAudioStream);
       });

diff --git a/packages/@webex/plugin-meetings/package.json b/packages/@webex/plugin-meetings/package.json
@@ -35,7 +35,7 @@
     "test:browser": "webex-legacy-tools test --integration --runner karma",
     "test:integration:broken": "webex-legacy-tools test --integration --runner mocha",
     "test:style": "eslint ./src/**/*.*",
-    "test:unit:broken": "webex-legacy-tools test --unit --runner mocha"
+    "test:unit": "webex-legacy-tools test --unit --runner mocha"
   },
   "devDependencies": {
     "@babel/core": "^7.17.10",

diff --git a/packages/@webex/plugin-meetings/src/meeting/index.ts b/packages/@webex/plugin-meetings/src/meeting/index.ts
@@ -4758,6 +4758,7 @@ export default class Meeting extends StatelessWebexPlugin {
       LoggerProxy.logger.error(
         `Meeting:index#startTranscription --> meeting joined : ${this.isJoined()}`
       );
+      throw new Error('Meeting is not joined');
     }
   }
 
@@ -4854,7 +4855,7 @@ export default class Meeting extends StatelessWebexPlugin {
     Trigger.trigger(
       this,
       {
-        file: 'meeting',
+        file: 'meeting/index',
         function: 'triggerStopReceivingTranscriptionEvent',
       },
       EVENT_TRIGGERS.MEETING_STOPPED_RECEIVING_TRANSCRIPTION

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/breakouts/breakout.ts b/packages/@webex/plugin-meetings/test/unit/spec/breakouts/breakout.ts
@@ -89,7 +89,7 @@ describe('plugin-meetings', () => {
         })
         };
 
-        sinon.stub(webex.internal.newMetrics.submitClientEvent, 'bind').returns(webex.internal.newMetrics.submitClientEvent);
+        const submitClientEventStub = sinon.stub(webex.internal.newMetrics.submitClientEvent, 'bind').returns(webex.internal.newMetrics.submitClientEvent);
 
         let onBreakoutMoveRequestStub = sinon.stub(breakoutEvent, 'onBreakoutMoveRequest');
         let onBreakoutMoveResponseStub = sinon.stub(breakoutEvent, 'onBreakoutMoveResponse');
@@ -105,6 +105,7 @@ describe('plugin-meetings', () => {
 
         onBreakoutMoveRequestStub.restore();
         onBreakoutMoveResponseStub.restore();
+        submitClientEventStub.restore()
       });
     });
 

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/breakouts/index.ts b/packages/@webex/plugin-meetings/test/unit/spec/breakouts/index.ts
@@ -381,7 +381,7 @@ describe('plugin-meetings', () => {
             id: 'meeting-id'
           })
         };
-        breakoutEvent.onBreakoutJoinResponse = sinon.stub();
+        const onBreakoutJoinResponseSpy = sinon.stub(breakoutEvent,'onBreakoutJoinResponse')
         breakouts.currentBreakoutSession.sessionId = "sessionId-old";
         breakouts.updateBreakout({
           sessionId: 'sessionId-new',
@@ -398,7 +398,9 @@ describe('plugin-meetings', () => {
           breakoutMoveId: 'breakoutMoveId',
         });
 
-        assert.calledOnce(breakoutEvent.onBreakoutJoinResponse);
+        assert.calledOnce(onBreakoutJoinResponseSpy);
+
+        onBreakoutJoinResponseSpy.restore()
 
       });
 
@@ -408,7 +410,7 @@ describe('plugin-meetings', () => {
             id: 'meeting-id'
           })
         };
-        breakoutEvent.onBreakoutJoinResponse = sinon.stub();
+        const onBreakoutJoinResponseSpy = sinon.stub(breakoutEvent, 'onBreakoutJoinResponse');
         breakouts.currentBreakoutSession.sessionId = "sessionId";
         breakouts.currentBreakoutSession.groupId = "groupId";
         breakouts.updateBreakout({
@@ -426,7 +428,8 @@ describe('plugin-meetings', () => {
           breakoutMoveId: 'breakoutMoveId',
         });
 
-        assert.notCalled(breakoutEvent.onBreakoutJoinResponse);
+        assert.notCalled(onBreakoutJoinResponseSpy);
+        onBreakoutJoinResponseSpy.restore()
 
       });
     });

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/media/index.ts b/packages/@webex/plugin-meetings/test/unit/spec/media/index.ts
@@ -7,6 +7,10 @@ import {forEach} from 'lodash';
 import MockWebex from '@webex/test-helper-mock-webex';
 
 describe('createMediaConnection', () => {
+  let clock;
+  beforeEach(() => {
+    clock = sinon.useFakeTimers();
+  });
   const webex = MockWebex();
 
   const fakeRoapMediaConnection = {
@@ -45,6 +49,7 @@ describe('createMediaConnection', () => {
   };
   afterEach(() => {
     sinon.restore();
+    clock.uninstall()
   });
 
   it('creates a RoapMediaConnection when multistream is disabled', () => {

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/meeting-info/meetinginfov2.js b/packages/@webex/plugin-meetings/test/unit/spec/meeting-info/meetinginfov2.js
@@ -826,18 +826,18 @@ describe('plugin-meetings', () => {
           statusCode: 200
         });
       });
-
       it('Make a request to /spaceInstant when conversationUrl with installed org ID', async () => {
         const {invitee} = setup();
-
+        webex.request = sinon.stub().resolves({
+          body: conversation,
+        });
         await meetingInfo.createAdhocSpaceMeeting(conversationUrl, installedOrgID);
 
-        assert.calledWith(
-          webex.internal.conversation.get,
-          {url: conversationUrl},
-          {includeParticipants: true, disableTransform: true}
-        );
-
+        assert.calledWith(webex.request, {
+          uri: conversationUrl,
+          qs: {includeParticipants: true},
+          disableTransform: true,
+        });
         assert.calledWith(webex.request, {
           method: 'POST',
           uri: 'https://go.webex.com/wbxappapi/v2/meetings/spaceInstant',