Update regex to handle newer exception message #96
Conversation
The exception message has apparently changed in newer version of Node.
| @@ -109,7 +109,7 @@ exports.first = function(predicate) { | |||
| rethrowUnlessFailedRequire = function(name, e) { | |||
| var rethrow = true; | |||
| if (e.code === 'MODULE_NOT_FOUND') { | |||
| var match = e.message.match(/^cannot find module '(.*)'$/i); | |||
There was a problem hiding this comment.
What's an old vs a new error message look like?
node's errors have a code property that's far more reliable than using the message (in node versions that have the code). Could we prefer using that, and fall back to message-based heuristics?
There was a problem hiding this comment.
The code is already being used on the previous line. The regex is being used to confirm that the missing module is actually the plugin trying to be loaded, not some other dependency (that's my assumption, anyway).
Test command:
node -r 'require("foo");'Node v12.4.1:
Error: Cannot find module 'require("foo");'
Require stack:
- internal/preload
Node v8.15.1:
Error: Cannot find module 'require("foo");'
|
I'm going to merge this, but would like to get all the CI builds passing again before releasing a new version. I don't have a ton of time to work on this right now though, so if you're interested in messing around with that, feel free. |
The exception message has apparently changed in newer version of Node.
Fix for #95.