feat(ui): upload dataset from csv #3826
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bcsherma
force-pushed
the
datset-csv-upload
branch
from
42e88dc to
3e0fa0b
Compare
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=d9e88ff0067d6c364676906baa36cb9efe97aaf6 |
bcsherma
force-pushed
the
datasets-page-refactor
branch
from
2d19152 to
4bab296
Compare
bcsherma
force-pushed
the
datset-csv-upload
branch
3 times, most recently
from
d4bafbb to
e8e1081
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
Have feedback? Participate in our User Experience Survey 📊 |
bcsherma
force-pushed
the
datasets-page-refactor
branch
from
4bab296 to
f6bf364
Compare
bcsherma
force-pushed
the
datset-csv-upload
branch
6 times, most recently
from
8f06e50 to
57969f5
Compare
bcsherma
commented
Mar 4, 2025
| @@ -44,6 +44,7 @@ interface CellViewingRendererProps { | |||
| isNew?: boolean; | |||
| isEditing?: boolean; | |||
| serverValue?: any; | |||
| disableNewRowHighlight?: boolean; | |||
There was a problem hiding this comment.
I thought the green highlight for "added rows" ruined this view, so I added a prop to disable.
| @@ -118,6 +118,7 @@ export const ResizableDrawer: React.FC<ResizableDrawerProps> = ({ | |||
| }} | |||
| onMouseDown={handleMouseDown} | |||
| /> | |||
| {headerContent} | |||
There was a problem hiding this comment.
header not being rendered here is an uncaught regression that this pr fixes
bcsherma
force-pushed
the
datset-csv-upload
branch
from
57969f5 to
4682504
Compare
bcsherma
force-pushed
the
datasets-page-refactor
branch
from
f6bf364 to
72ebfc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a "New dataset" button to the datasets page. Clicking the button opens a drawer which allows the user to upload a csv, make edits, and publish the result as a new dataset.
Screen.Recording.2025-03-04.at.1.42.18.PM.mov
This PR adds papaparse as a dependency for
weave-js