Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add analytic event to metrics chart views #3570

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Feb 1, 2025

Description

Add analytics for the metrics plot. Includes a latency metric which could be interesting to see if users are running into perf issues.

@gtarpenning gtarpenning marked this pull request as ready for review February 1, 2025 00:05
@gtarpenning gtarpenning requested review from a team as code owners February 1, 2025 00:05
@circle-job-mirror
Copy link

circle-job-mirror bot commented Feb 1, 2025

@@ -114,6 +115,29 @@ export const CallsCharts = ({
columns
);

const [callsQueryStartTime, setCallsQueryStartTime] = useState<number | null>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to pull this into its own hook to reduce component code

@gtarpenning gtarpenning requested a review from tssweeney February 1, 2025 01:21
@gtarpenning gtarpenning enabled auto-merge (squash) February 11, 2025 19:09
@gtarpenning gtarpenning requested a review from bcsherma February 11, 2025 19:09
@gtarpenning gtarpenning merged commit 59c726f into master Feb 11, 2025
126 checks passed
@gtarpenning gtarpenning deleted the griffin/analytics-metrics-plot branch February 11, 2025 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants