Skip to content

Commit

Permalink
feat(weave): enable latency, status sorting in trace table
Browse files Browse the repository at this point in the history
  • Loading branch information
bcsherma committed Feb 27, 2025
1 parent 24e73a8 commit 446f7ca
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ export type FilterId = number | string | undefined;
export const UNFILTERABLE_FIELDS = [
'op_name',
'feedback',
'status',
'summary.weave.status',
'summary.weave.latency_ms',
'tokens',
'cost',
'latency',
'wb_user_id', // Option+Click works
];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,10 @@ function buildCallsTableColumns(
// },
// },
{
field: 'status',
field: 'summary.weave.status',
headerName: 'Status',
headerAlign: 'center',
sortable: false,
sortable: true,
// disableColumnMenu: true,
resizable: false,
width: 59,
Expand Down Expand Up @@ -618,14 +618,14 @@ function buildCallsTableColumns(
});

cols.push({
field: 'latency',
field: 'summary.weave.latency_ms',
headerName: 'Latency',
width: 100,
minWidth: 100,
maxWidth: 100,
// Should probably have a custom filter here.
filterable: false,
sortable: false,
sortable: true,
valueGetter: (unused: any, row: any) => {
if (traceCallStatusCode(row) === 'UNSET') {
// Call is still in progress, latency will be 0.
Expand Down

0 comments on commit 446f7ca

Please sign in to comment.