Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): handle ref unmounting in conditional updates #12900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inottn
Copy link
Contributor

@inottn inottn commented Feb 17, 2025

fix #12898

Copy link

pkg-pr-new bot commented Feb 17, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12900

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12900

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12900

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12900

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12900

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12900

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12900

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12900

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12900

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12900

vue

npm i https://pkg.pr.new/vue@12900

commit: c30b8c2

Copy link

github-actions bot commented Feb 18, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+46 B) 38.1 kB (+19 B) 34.4 kB (+38 B)
vue.global.prod.js 158 kB (+46 B) 58 kB (+22 B) 51.6 kB (+5 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB (+46 B) 18.3 kB (+17 B) 16.7 kB (+16 B)
createApp 54.6 kB (+46 B) 21.3 kB (+18 B) 19.5 kB (+15 B)
createSSRApp 58.8 kB (+46 B) 23 kB (+16 B) 21 kB (+23 B)
defineCustomElement 59.4 kB (+46 B) 22.9 kB (+17 B) 20.8 kB (+12 B)
overall 68.7 kB (+46 B) 26.5 kB (+21 B) 24 kB (+18 B)

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The template ref was not set to null correctly after the conditional rendering was updated
2 participants