Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ProductImages.md #1130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ProductImages.md #1130

wants to merge 1 commit into from

Conversation

barbara-celi
Copy link
Contributor

What problem is this solving?

Added the accepted video formats.

How to test it?

[Workspace](Link goes here!)

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@barbara-celi barbara-celi self-assigned this Feb 21, 2025
@barbara-celi barbara-celi requested a review from a team as a code owner February 21, 2025 17:43
@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 21, 2025 •
edited by barbara-celi
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@github-actions GitHub Actions
Copy link

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 🚫 dangerJS against 9533391

carolinamenezes
carolinamenezes requested changes Feb 24, 2025
View reviewed changes
docs/ProductImages.md
Comment on lines +9 to +20
The accepted video formats are the following. Remember to replace `{VIDEO_ID}` according to your scenario.

**Vimeo**

- `https://vimeo.com/{VIDEO_ID}`

**Youtube**

- `https://youtu.be/{VIDEO_ID}`
- `https://www.youtube.com/watch?v={VIDEO_ID}`
- `https://www.youtube.com/embed/{VIDEO_ID}`
- `https://www.youtube.com/v/{VIDEO_ID}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Achei que essa info tá meio solta. Qual prop recebe essa info?
O ProductImages aceita tanto imagem quanto vídeo. Acho que seria bom especificar o formato das imagens também

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validei com a Julia, e o link da vídeo é inserido diretamente no catálogo. Vou retirar essa info daqui e colocar na doc correta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinamenezes carolinamenezes carolinamenezes requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@barbara-celi barbara-celi

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barbara-celi @carolinamenezes