[SFS-2085] refactor: sortVariationsByLabel logic when not numbers and redability #1112
iago1501Annotations
10 errors and 17 warnings
|
|
|
Lint:
react/components/SKUSelector/components/SKUSelector.tsx#L89
Replace `.slice().sort((a,·b)·=>·parseFloat(a.label)·-·parseFloat(b.label));` with `⏎····.slice()⏎····.sort((a,·b)·=>·parseFloat(a.label)·-·parseFloat(b.label))`
|
|
|
|
|
|
|
|
|
|
Lint:
react/components/SKUSelector/components/SKUSelector.tsx#L295
Delete `······⏎`
|
|
|
|
Lint:
react/components/SKUSelector/components/SKUSelector.tsx#L300
Unexpected use of 'isNaN'
|
|
Lint:
react/components/SKUSelector/components/SKUSelector.tsx#L304
Replace `?·sortOptionsNumerically({...options` with `··?·sortOptionsNumerically({·...options·`
|
|
Lint
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v1. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
|
|
IO app test
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v1. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
|
|
Danger CI
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
IO app test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
IO app test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Lint:
react/__tests__/components/ProductDescription.test.tsx#L7
Unexpected any. Specify a different type
|
|
Lint:
react/__tests__/components/SKUSelector.test.tsx#L11
Unexpected any. Specify a different type
|
|
Lint:
react/components/BuyButton/assemblyUtils.test.ts#L109
Forbidden non-null assertion
|
|
Lint:
react/components/GradientCollapse/index.d.ts#L3
Unexpected any. Specify a different type
|
|
Lint:
react/components/ProductImages/components/ProductImageContext.ts#L8
Unexpected any. Specify a different type
|
|
Lint:
react/components/SKUSelector/components/SKUSelector.tsx#L96
Expected blank line before this statement
|
|
Lint:
react/components/SanitizedHTML.tsx#L93
Unexpected any. Specify a different type
|
|
Lint:
react/components/SearchBar/AutocompleteInput.tsx#L57
Unexpected any. Specify a different type
|
|
Lint:
react/components/SearchBar/AutocompleteInput.tsx#L59
Unexpected any. Specify a different type
|
|
Lint:
react/components/SearchBar/AutocompleteInput.tsx#L91
Unexpected any. Specify a different type
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|