Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dp variant validation #695

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

hiagolcm
Copy link
Contributor

What problem is this solving?

We will not use osiris anymore so we can remove the variant validation that we do before rendering the component

How to test it?

Workspace

@hiagolcm hiagolcm requested review from a team as code owners February 26, 2025 12:53
@hiagolcm hiagolcm requested review from vsseixaso, RodrigoTadeuF and leo-prange-vtex and removed request for a team February 26, 2025 12:53
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 26, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 26, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@hiagolcm hiagolcm merged commit 9672a99 into master Feb 26, 2025
10 checks passed
@hiagolcm hiagolcm deleted the feature/remove-variant-validation branch February 26, 2025 13:23
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 26, 2025

Your PR has been merged! App is being published. 🚀
Version 3.136.0 → 3.136.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.search-result@3.136.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants