Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/admin reply #41

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature/admin reply #41

wants to merge 9 commits into from

Conversation

wender
Copy link
Collaborator

@wender wender commented Nov 17, 2020

What problem is this solving?

Adding reply functionality

How to test it?

Head over to the admin, click on the review, a reply modal will show up
image

Workspace

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@wender wender requested review from a team as code owners November 17, 2020 17:33
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 17, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@github-actions
Copy link

github-actions bot commented Nov 17, 2020

Fails
🚫

No @context(provider: "...") found on reply.graphql. Please explicitly declare the query provider.

Warnings
⚠️

👀 The size of this pull request seems relatively large (>420 modifications). Consider splitting it into smaller pull requests to help make reviews easier and faster.

Generated by 🚫 dangerJS against 5005274

var response = await client.SendAsync(request);
string responseContent = await response.Content.ReadAsStringAsync();

Console.WriteLine($"GetUserData '{userId}' [{response.StatusCode}] {responseContent}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed?

},
})

const sessionResponse: any = useSessionResponse()
Copy link
Contributor

@klzns klzns Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the backend can read the session cookies and get the values there instead of doing this on the frontend. What do you think? It's a safer option

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, will talk to Brian

Copy link
Contributor

@guerreirobeatriz guerreirobeatriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this new functionality should be clarified in the docs! I only see the new Handles, but how the reply modal should be enabled? Is it enabled by default, no further actions required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants