-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/admin reply #41
base: master
Are you sure you want to change the base?
Conversation
…views-and-ratings into feature/admin-reply
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
|
var response = await client.SendAsync(request); | ||
string responseContent = await response.Content.ReadAsStringAsync(); | ||
|
||
Console.WriteLine($"GetUserData '{userId}' [{response.StatusCode}] {responseContent}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed?
}, | ||
}) | ||
|
||
const sessionResponse: any = useSessionResponse() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the backend can read the session cookies and get the values there instead of doing this on the frontend. What do you think? It's a safer option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, will talk to Brian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this new functionality should be clarified in the docs! I only see the new Handles, but how the reply modal should be enabled? Is it enabled by default, no further actions required?
What problem is this solving?
Adding reply functionality
How to test it?
Head over to the admin, click on the review, a reply modal will show up

Workspace
Screenshots or example usage:
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
