-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(acessibility): added aria properties to resolve accessibility is… (
#73) #### What problem is this solving? Drawer ajuste apontado pelo Lighthouse: "Os elementos [aria-hidden="true"] contêm descendentes focalizáveis" Alterado a lógica para valor do atributo aria-hidden, pois quando o minicart não está aberto, o botão deve ter o atributo aria-hidden="false" e não "true". E quando o minicart estiver aberto, esses valores devem se inverter, ou seja, o botão receber o atributo aria-hidden="true", já que agora o minicart é exibido e o botão não. DrawerCloseButton foi adicionado aria-label e id para facilitar a identificação aos leitores de tela. Swipable foi removido o atributo aria-hidden, pois também estava impactando na acessibilidade apontada pelo LightHouse: "Os elementos [aria-hidden="true"] contêm descendentes focalizáveis". #### How to test it? [Workspace](https://www.samsclub.com.br/?workspace=testeacessibilidade) Executar o teste no Lighthouse ou PageSpeed. #### Screenshots or example usage: Antes da alteração:  Depois da alteração (o ajuste não foi mais apontado pelo Lighthouse):  Antes da alteração:  Depois da alteração (o ajuste não foi mais apontado pelo Lighthouse):  --------- Co-authored-by: joao.congio <joao.congio@corebiz.ag>
- Loading branch information
1 parent
a334297
commit 344c0fc
Showing
6 changed files
with
16 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"admin/editor.drawer.title": "Drawer" | ||
} | ||
"admin/editor.drawer.title": "Drawer", | ||
"store/drawer.close-button": "drawer.close-button" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"admin/editor.drawer.title": "Drawer" | ||
} | ||
"admin/editor.drawer.title": "Drawer", | ||
"store/drawer.close-button": "Close" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"admin/editor.drawer.title": "Drawer" | ||
} | ||
"admin/editor.drawer.title": "Drawer", | ||
"store/drawer.close-button": "Fechar" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 comment
on commit 344c0fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olá @lariciamota , aparentemente com esta ultima atualização o componente drawer perdeu a configuração do "eager" localizada na documentação da vtex, esta estratégia de renderização é importante para o SEO por conta da renderização dos links permitindo que o crawler entenda, já da forma que está o carregamento dos links dependem da interação do usuário.
Documentação do drawe onde possui a estratégia de renderização do eager:
https://developers.vtex.com/docs/apps/vtex.store-drawer
This change is not ok.