Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Source - List of Contributions of the App #42

Open
OldMetalmind opened this issue Aug 16, 2019 · 3 comments
Open

Data Source - List of Contributions of the App #42

OldMetalmind opened this issue Aug 16, 2019 · 3 comments
Assignees

Comments

@OldMetalmind
Copy link
Member

OldMetalmind commented Aug 16, 2019

Related issue 17

In the app we want to list all contributions, so we need an endpoint to feed the app.

We will have a file in assets with the list of all contributors

@OldMetalmind OldMetalmind self-assigned this Aug 16, 2019
@OldMetalmind OldMetalmind added this to the v1.0.0 - Akita milestone Aug 16, 2019
@Vanethos
Copy link
Contributor

Vanethos commented Oct 7, 2019

We will need the following to form this:

  • Github username
  • User's name (if available)
  • Profile picture URL
  • Profile URL (should be github.com/userName)
  • The type of help that was provided - copy, design, development - Category

When we are preparing for a release, we will need to deploy the asset file.

As for now, and to update issue #17, @OldMetalmind can you please accept this structure?

{
    "username": "String",
     "name": "String",
     "profilePicture": "String"
      "category": CategoryEnum
}

With Category enum having the values:

copy,
design,
development

If this is approved, then I will post this in the issue

@Vanethos
Copy link
Contributor

Vanethos commented Oct 7, 2019

This was discussed in a private conversation with the feedback for adding the field category

The original issue will be updated

@Vanethos
Copy link
Contributor

Vanethos commented Oct 16, 2019

As of now:

[{
        "username": "Vanethos",
        "profileUrl": "https://github.com/Vanethos",
        "name": "Gonçalo Palma",
        "profilePicture": "https://avatars0.githubusercontent.com/u/10728633?s=460&v=4",
        "category": "development"
    },
    {
        "username": "OldMetalmind",
        "profileUrl": "https://github.com/OldMetalmind",
        "name": "Filipe Barroso",
        "profilePicture": "https://avatars1.githubusercontent.com/u/404874?s=460&v=4",
        "category": "development"
    },
    {
        "username": "lima21",
        "profileUrl": "https://github.com/lima21",
        "name": "Gonçalo Lima",
        "profilePicture": "https://avatars2.githubusercontent.com/u/16529736?s=460&v=4,
        "category": "development"
    },
    {
        "username": "404shades",
        "profileUrl": "https://github.com/404shades",
        "name": "Rohan Malik",
        "profilePicture": "https://avatars1.githubusercontent.com/u/22107134?s=460&v=4",
        "category": "development"
    },
    {
        "username": "TomerPacific",
        "profileUrl": "https://github.com/TomerPacific",
        "name": "Tomer Ben-Rachel",
        "profilePicture": "https://avatars1.githubusercontent.com/u/23402988?s=460&v=4",
        "category": "development"
    },
    {
        "username": "",
        "profileUrl": "https://dribbble.com/ffrutuoso",
        "name": "Francisco Frutuoso",
        "profilePicture": "https://cdn.dribbble.com/users/462982/avatars/normal/b5f85fad3d918de82df3902394c777ef.jpg?1523271582",
        "category": "design"
    },
    {
        "username": "",
        "profileUrl": "https://twitter.com/BicaCurta/photo",
        "name": "Jorge Gomes",
        "profilePicture": "https://pbs.twimg.com/profile_images/1080934978006011907/Se_YpAPL_400x400.jpg",
        "category": "copy"
    }
]

I need your opinion on the following:

  • Order: it was the order provided by github
  • Profile URL: in the case of Francisco and Jorge, I added their Dribbble and Twitter profiles respetively, with no username.
  • Category: in your case @OldMetalmind you helped out with all three categories, so do we want to have multiple values in the category parameter? Or should we focus only on the main contributions?

Any feedback and help on this json is greatly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants