Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors Screen #17

Closed
Vanethos opened this issue Aug 14, 2019 · 8 comments
Closed

Contributors Screen #17

Vanethos opened this issue Aug 14, 2019 · 8 comments
Assignees
Labels
hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these! Needs Maintainers Help The maintainer is needed for something

Comments

@Vanethos
Copy link
Contributor

Vanethos commented Aug 14, 2019

Description
Create screen with all the contributors for the app

File Location

- presentation
|__ ui

Requirements

  • From the Github API, get the current contributors information and display it in form of list with:
    • User image
    • User Name
    • User description

UI
imagem

Notes
Expect the following object:

{
    "username": "String",
     "name": "String",
     "profilePicture": "String"
      "category": CategoryEnum
}

With Category enum having the values:

copy,
design,
development
@Vanethos
Copy link
Contributor Author

@OldMetalmind We need to analyze this issue:

  • How are we getting Github data? In the case of FOGOS, they created an endpoint dedicated to this

  • The copy for this screen must be added

@Vanethos Vanethos added the Needs Maintainers Help The maintainer is needed for something label Aug 14, 2019
@OldMetalmind
Copy link
Member

OldMetalmind commented Aug 16, 2019

Created two issues to take care of the two pending topics

@AmaldevAD
Copy link

AmaldevAD commented Oct 2, 2019

do u have api for this particular app?

@OldMetalmind
Copy link
Member

We have an API for the app itself, however, for this task at hand, we will be loading the contributors from a JSON file in the assets in this first version.
If you desire to contribute to this task, please recommend a JSON structure for contributors that can have different backgrounds, such as designers, copy, coders.

@Vanethos Vanethos added the hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these! label Oct 7, 2019
@Vanethos
Copy link
Contributor Author

Vanethos commented Oct 7, 2019

The issue was updated with the expected JSON object.

@Vanethos Vanethos assigned Vanethos and unassigned Vanethos Oct 15, 2019
@Lima21
Copy link
Contributor

Lima21 commented Oct 17, 2019

I will do this issue

@Vanethos Vanethos assigned Vanethos and Lima21 and unassigned Vanethos Oct 17, 2019
@Vanethos
Copy link
Contributor Author

@Lima21 Any news on this issue?

@Vanethos
Copy link
Contributor Author

closed via #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these! Needs Maintainers Help The maintainer is needed for something
Projects
None yet
Development

No branches or pull requests

4 participants