Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spring library #43

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Remove spring library #43

merged 1 commit into from
Mar 25, 2024

Conversation

magwitch324
Copy link
Contributor

This change bumps the version of spring-web from 6.0.14 to 6.0.18

It also fixes two problems preventing the project from building. Specifically an incorrect version for jackson-databind, and making the build use a specific version of node.

@vmwclabot
Copy link
Member

@magwitch324, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@magwitch324, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@magwitch324 magwitch324 requested a review from unckit March 20, 2024 15:26
@magwitch324
Removed spring from project
c81a028 
This change removes spring libraries from this project. They are unused
and were on old versions.

It also fixes two problems preventing the project from building.
Specifically an incorrect version for jackson-databind, and making the
build use a specific version of node.

Signed-off-by: Thomas Grimshaw <grimshawthom@vmware.com>
@magwitch324 magwitch324 changed the title Bump spring-web to 6.0.18 Remove spring library Mar 20, 2024
@magwitch324
Copy link
Contributor Author

Switched to removing spring libraries as they are unused

@magwitch324 magwitch324 merged commit d7db4aa into vmware:master Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unckit unckit Awaiting requested review from unckit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magwitch324 @vmwclabot