Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from gitlab mirror_vcd-api-schemas branch to github vmware/vcd-api-schemas #14

Open
wants to merge 9 commits into
base: v10.0
Choose a base branch
from

Conversation

rajeshk2013
Copy link

It includes changes for
1: Updating schemas and yaml files
2: Added python dependencies
3: Added file to push to PyPi

@jmoroski @shashim22 @pgowdavmw

rajeshk2013 and others added 4 commits February 10, 2020 23:55
Created a seperated child poject for python that is capable of triggering mvn plugin for python.

Testing Done: Manually copied the vcd-binding generator for python to the local m2 repo and generated the python type classes and checked using flake8 and found no issue.

Signed-off-by: Rajesh Kumar <rajeshk@vmware.com>
Shell script publish.sh can be used to push the end-deliverable to pypi.

Testing Done: Manually executed and inspected the package by un-archieving it. It bundles both xsd based and open-api python generated types correctly.

Location would be /vcd-api-schemas-type-9.1.2.dev1/vcloud/

Signed-off-by: Rajesh Kumar <rajeshk@vmware.com>
This commit updates the schemas for REST and Swagger-based APIs to vCD
10.0.

Testing Done:
Verified that a mvn clean install completed successfully.

Signed-off-by: Shashi Mohan <shashim@vmware.com>
Testing Done: Un-Archieve the end deliverable file and validated manually

Signed-off-by: Rajesh Kumar <rajeshk@vmware.com>
@rajeshk2013 rajeshk2013 changed the base branch from master to v10.0 February 26, 2020 11:10
Testing Done: Executed the publish.sh file and inspected the deliverable file after archieving the file

Signed-off-by: Rajesh Kumar <rajeshk@vmware.com>
@vmwclabot
Copy link
Member

@rajeshk2013, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@rajeshk2013, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Jeff Moroski added 3 commits March 3, 2020 07:15
Be explicit about dist and JDK version.

Signed-off-by: Jeff Moroski <jmoroski@vmware.com>
Travis CI builds had previously stopped working. They are working again after a migration, except that the "deploy to public repos" process is still broken. The fact that this situation occurred without any corresponding code or config changes doesn't instill a whole lot of confidence in terms of build reproducibility.

Interested parties recommended moving to GitHub Actions. This review does that.

Signed-off-by: Jeff Moroski <jmoroski@vmware.com>
Signed-off-by: Jeff Moroski <jmoroski@vmware.com>
Signed-off-by: Rajesh Kumar<rajeshk@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants