Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump sigs.k8s.io/controller-runtime from 0.6.0 to 0.20.0 #495

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps sigs.k8s.io/controller-runtime from 0.6.0 to 0.20.0.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.20.0

Highlights

  • Based on k8s.io/* v1.32 libraries and minimum Go version is now v1.23
  • New experimental priority queue feature
    • More details in #3013 and #2374
    • Can be enabled via manager.Options.Controller.UsePriorityQueue
    • Please give it a try and provide feedback in #2374
  • AggregatedDiscovery is automatically used when available (#2901)
  • As usual, many improvements to the fake client

Changes since v0.19.0

⚠️ Breaking Changes

  • Bump to k8s.io/* v1.32 libraries (#2971 #2990 #3001 #3007 #3029 #3043)
  • logging: Stop deduplicating API warnings by default (#2953)
  • webhook: Stop deleting unknown fields in CustomDefaulter (#2982 #3056)
  • webhook: Remove deprecated Defaulter and Validator (#2877 #2945)
  • cluster: Remove deprecated SyncPeriod option (#2970)

✨ New Features

  • cache: Add EnableWatchBookmarks option (defaults to true) (#3017)
  • cache: Export NewInformer option (#3061)
  • cert-watcher: Add polling (#3020 #3050)
  • controller: Add experimental priority queue (off per default) (#3013 #3014 #3060 #3066)
  • fake client: Allow adding indexes at runtime (#3021)
  • fake client: Add support for ServiceAccountToken subresource (#2969)
  • restmapper: Use AggregatedDiscovery if available (#2901)
  • util: Add HasOwnerReference func (#2882)
  • webhook: Add custom path option (#2998)

🐛 Bug Fixes

  • controller: Error when source.Start() never returns (#2997 #3006 #3008)
  • fake client: Don't return items on invalid selector (#3022)
  • fake client: Fix TOCTOU races (#2980)
  • fake client: Preserve TypeMeta during Get call with PartialObjectMeta (#2949)
  • fake client: Preserve TypeMeta during List call with UnstructuredList (#3074)
  • manager: Fix RenewDeadline typo in leader election (#3032)
  • manager: Use leader elector with client timeout (#3028 #3034)

🌱 Others

  • cache: Switch to Go 1.23+ stdlib maps/slices packages (#3012)
  • controller: Log the syncing source when WaitForSync fails (#3016)
  • setup-envtest: drop support for GCS (#2915)
  • Some fixes for typos (#3011 #3033 #2993)

... (truncated)

Commits
  • 8f7e114 Merge pull request #3074 from sbueringer/pr-fix-fake-list
  • 3b23354 fake client: preserve TypeMeta during List call with UnstructuredList
  • 1ec7c1b Merge pull request #3069 from kubernetes-sigs/dependabot/github_actions/all-g...
  • 189b6d8 🌱 Bump the all-github-actions group across 1 directory with 3 updates
  • d19d76c Merge pull request #3066 from alvaroaleman/fix-wow
  • e667a8f 🐛 Fix a bug in the priorityqueue metrics
  • 1de5a3e Merge pull request #3062 from ranakan19/cache_options
  • 2484715 Merge pull request #3064 from alvaroaleman/remove-gosec
  • 3b0b995 🌱 Remove gosec linter
  • c80ea33 Merge pull request #3060 from alvaroaleman/pq-2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Dependencies go Pull requests that update Go code labels Jan 20, 2025
@dependabot dependabot bot requested a review from a team January 20, 2025 00:35
@github-actions github-actions bot added chore Chore provider Provider needs-review Needs Review labels Jan 20, 2025
@tenthirtyam tenthirtyam requested a review from vivgoyal January 21, 2025 15:01
k8s.io/apiextensions-apiserver v0.32.0
k8s.io/apimachinery v0.32.0
k8s.io/client-go v0.32.0
sigs.k8s.io/controller-runtime v0.20.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit hesitant on this without running some tests. Controller runtime has been known to create issues sometimes between versions and this is a long jump

tenthirtyam
tenthirtyam previously approved these changes Jan 23, 2025
@tenthirtyam
Copy link
Contributor

@dependabot rebase

@tenthirtyam tenthirtyam dismissed their stale review January 23, 2025 01:52

Awaiting tests

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.6.0 to 0.20.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.6.0...v0.20.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.20.0 branch from 082c91e to b3bda7e Compare January 23, 2025 01:52
@tenthirtyam
Copy link
Contributor

Seems that v0.6.0 is from 2020.

Definitely needs some testing but given the age, an update may be warranted for consideration after successful tests.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 27, 2025

Superseded by #499.

@dependabot dependabot bot closed this Jan 27, 2025
@dependabot dependabot bot deleted the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.20.0 branch January 27, 2025 00:19
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore dependencies Dependencies go Pull requests that update Go code provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants