Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh auth context while polling for clustergroup backupschedule #393

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

rnarenpujari
Copy link
Contributor

  1. What this PR does / why we need it:

Missed one case in this earlier PR: #390

The acceptance tests for this resource are failing for a different reason and that is being tracked separately. This is a minor change and should not cause any regression.

  1. Which issue(s) this PR fixes

     (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):
    
     Fixes #
    
  2. Additional information

  3. Special notes for your reviewer

@rnarenpujari rnarenpujari self-assigned this Mar 26, 2024
@vmwclabot
Copy link
Member

@rnarenpujari, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Mar 26, 2024
Signed-off-by: Rahul Naren Pujari <rnarenpujari@gmail.com>
@rnarenpujari rnarenpujari force-pushed the rnarenpujari/dp-auth branch from 1ca7d5a to ff99714 Compare March 27, 2024 04:16
@vmwclabot vmwclabot removed the dco-required DCO Required label Mar 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.23%. Comparing base (db5c3cd) to head (ff99714).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   25.23%   25.23%           
=======================================
  Files         195      195           
  Lines       16908    16908           
=======================================
  Hits         4267     4267           
  Misses      12423    12423           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@eastaga eastaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rnarenpujari rnarenpujari merged commit 0de7b8a into main Apr 1, 2024
4 checks passed
@tenthirtyam tenthirtyam deleted the rnarenpujari/dp-auth branch November 13, 2024 06:37
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants