Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opaque secret type #385

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

warroyo
Copy link
Contributor

@warroyo warroyo commented Mar 18, 2024

  1. What this PR does / why we need it:
    This adds the ability to use opaque secret type with the k8s secret resource

@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Mar 18, 2024
@warroyo warroyo force-pushed the add-opaque-secret-type branch from ad0a35f to 9ca126c Compare March 18, 2024 20:00
@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@warroyo warroyo force-pushed the add-opaque-secret-type branch from 9ca126c to 4e3a2bb Compare March 18, 2024 20:11
@vmwclabot vmwclabot removed the dco-required DCO Required label Mar 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 18.26923% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 25.23%. Comparing base (102b2ad) to head (d5171ca).
Report is 2 commits behind head on main.

Files Patch % Lines
internal/resources/kubernetessecret/spec/spec.go 0.00% 35 Missing ⚠️
...l/resources/kubernetessecret/spec/cluster_scope.go 41.46% 21 Missing and 3 partials ⚠️
...rnal/resources/kubernetessecret/resource_secret.go 0.00% 18 Missing ⚠️
...l/resources/kubernetessecret/data_source_secret.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   25.31%   25.23%   -0.08%     
==========================================
  Files         195      195              
  Lines       16845    16908      +63     
==========================================
+ Hits         4264     4267       +3     
- Misses      12363    12423      +60     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vmw-vjn
Copy link

vmw-vjn commented Mar 19, 2024

@AkbaraliShaikh - can you kindly review and add/append to this PR wrt TMC-56160

cc: @shobha2626 / @ramya-bangera

@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Mar 19, 2024
@AkbaraliShaikh AkbaraliShaikh force-pushed the add-opaque-secret-type branch from 260b55d to e19a536 Compare March 19, 2024 09:32
@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@shobha2626
Copy link
Contributor

@AkbaraliShaikh - can you kindly review and add/append to this PR wrt TMC-56160

cc: @shobha2626 / @ramya-bangera

@vmw-vjn Documentation and acceptance changes are missing in the PR. We would need them before making the release with this change

Copy link
Contributor

@shobha2626 shobha2626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @warroyo for adding the opaque secret support.

Please sign and align/squash the commits with meaningful messages

@AkbaraliShaikh AkbaraliShaikh force-pushed the add-opaque-secret-type branch from e19a536 to 18777e9 Compare March 19, 2024 10:14
@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@AkbaraliShaikh
Copy link
Contributor

@AkbaraliShaikh - can you kindly review and add/append to this PR wrt TMC-56160

cc: @shobha2626 / @ramya-bangera

@warroyo I have fixed/updated the following in my commit

  • opaque update was not working - fixed
  • updated the documentation
  • fixed the lint errors

Can you please update the acceptance tests?

@AkbaraliShaikh AkbaraliShaikh force-pushed the add-opaque-secret-type branch from 18777e9 to d731693 Compare March 19, 2024 10:46
@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@AkbaraliShaikh AkbaraliShaikh force-pushed the add-opaque-secret-type branch from d731693 to 9147803 Compare March 19, 2024 15:53
@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

2 similar comments
@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@warroyo warroyo force-pushed the add-opaque-secret-type branch from 6f38a37 to 56b562d Compare March 19, 2024 17:18
@vmwclabot vmwclabot removed the dco-required DCO Required label Mar 19, 2024
@warroyo warroyo force-pushed the add-opaque-secret-type branch from 56b562d to d416491 Compare March 19, 2024 20:01
Signed-off-by: Will Arroyo <warroyo7199008@gmail.com>
@warroyo warroyo force-pushed the add-opaque-secret-type branch from d416491 to d5171ca Compare March 19, 2024 20:29
Copy link
Contributor

@shobha2626 shobha2626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkbaraliShaikh / @warroyo could you pease share the screenshot of successful mock test and acceptance test screenshot?

@AkbaraliShaikh
Copy link
Contributor

AkbaraliShaikh commented Mar 20, 2024

@AkbaraliShaikh / @warroyo could you pease share the screenshot of successful mock test and acceptance test screenshot?

image

image

@AkbaraliShaikh AkbaraliShaikh merged commit 4b4230f into vmware:main Mar 20, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants