-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opaque secret type #385
Conversation
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
ad0a35f
to
9ca126c
Compare
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
9ca126c
to
4e3a2bb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 25.31% 25.23% -0.08%
==========================================
Files 195 195
Lines 16845 16908 +63
==========================================
+ Hits 4264 4267 +3
- Misses 12363 12423 +60
Partials 218 218 ☔ View full report in Codecov by Sentry. |
@AkbaraliShaikh - can you kindly review and add/append to this PR wrt TMC-56160 cc: @shobha2626 / @ramya-bangera |
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
260b55d
to
e19a536
Compare
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@vmw-vjn Documentation and acceptance changes are missing in the PR. We would need them before making the release with this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @warroyo for adding the opaque secret support.
Please sign and align/squash the commits with meaningful messages
e19a536
to
18777e9
Compare
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@warroyo I have fixed/updated the following in my commit
Can you please update the acceptance tests? |
18777e9
to
d731693
Compare
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
d731693
to
9147803
Compare
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
2 similar comments
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
6f38a37
to
56b562d
Compare
56b562d
to
d416491
Compare
Signed-off-by: Will Arroyo <warroyo7199008@gmail.com>
d416491
to
d5171ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkbaraliShaikh / @warroyo could you pease share the screenshot of successful mock test and acceptance test screenshot?
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This adds the ability to use opaque secret type with the k8s secret resource