Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed eks acceptance testing related issue #383

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

snootan
Copy link
Contributor

@snootan snootan commented Mar 1, 2024

  1. What this PR does / why we need it:
    As part of this, we have fixed issue related to acceptance EKS testing.
  2. Which issue(s) this PR fixes
    N/A
  3. Additional information
    In the terraform automation the ekscluster acceptance tests started failing again , looks like it is due to some recent change to the resource.
    Below the error snippet:

  1. Special notes for your reviewer

Signed-off-by: Nootan Singh <snootan@vmware.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.31%. Comparing base (7b21fe2) to head (22506a4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   25.31%   25.31%           
=======================================
  Files         195      195           
  Lines       16845    16845           
=======================================
  Hits         4264     4264           
  Misses      12363    12363           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snootan snootan merged commit 102b2ad into main Mar 2, 2024
4 checks passed
@ramya-bangera ramya-bangera deleted the issue/eks-acceptance-testing-vpc branch March 4, 2024 06:25
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants