Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AKS acceptance/mock tests to use kubernetes 1.27.9 #382

Merged

Conversation

gshaw-pivotal
Copy link
Contributor

  1. What this PR does / why we need it:

AKS acceptance tests started failing as the kubernetes version they use (1.26.6) is no longer available in the Azure region the test executes against. Updated to kubernetes version 1.27.9

  1. Which issue(s) this PR fixes

N/A

  1. Additional information
  • Kubernetes 1.26.x in Azure is reaching EOL and various patch versions are starting to become unavailable for use.
  • Kubernetes 1.27 has EOL in Jul 2024 and LTS until Jul 2025.
  • To make it easier to update the version in the future, added a variable to hold the version string. Future updates only therefore need to change the value of this variable
  1. Special notes for your reviewer

Tested locally in both mock and acceptance mode (against real stack).

@vmwclabot
Copy link
Member

@gshaw-pivotal, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Feb 23, 2024
- Kubernetes 1.26.x in Azure is reaching EOL and various patch versions
  are starting to become unavailable for use.
- Kubernetes 1.27 has EOL in Jul 2024 and LTS until Jul 2025.
- To make it easier to update the version in the future, added a
  variable to hold the version string.

Signed-off-by: Gavin Shaw <gavins@vmware.com>
Signed-off-by: Gavin Shaw <gshaw+github@pivotal.io>
@gshaw-pivotal gshaw-pivotal force-pushed the update-aks-acceptance-testing-kubernetes-version branch from c06ec5b to 663f12f Compare February 23, 2024 19:57
@vmwclabot vmwclabot removed the dco-required DCO Required label Feb 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.31%. Comparing base (7b21fe2) to head (663f12f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   25.31%   25.31%           
=======================================
  Files         195      195           
  Lines       16845    16845           
=======================================
  Hits         4264     4264           
  Misses      12363    12363           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ramya-bangera ramya-bangera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking it on priority

@gshaw-pivotal gshaw-pivotal merged commit 5a878f5 into main Feb 27, 2024
4 checks passed
@tenthirtyam tenthirtyam deleted the update-aks-acceptance-testing-kubernetes-version branch November 13, 2024 06:37
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants