Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the namespace acceptance tests #381

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

ramya-bangera
Copy link
Contributor

Provider configuration has the wrong provider name as "tmc" instead of "tanzu-mission-control" causing the tests to fail. Modified the test to use the common provider testing code instead of the incorrect one.

  1. What this PR does / why we need it:
    Fixes the failing namespace acceptance tests

  2. Which issue(s) this PR fixes

     (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):
    
     Fixes issue tracked in internal Jira
    
  3. Additional information

  4. Special notes for your reviewer

namespace % go test -v -tags=namespace                                     
=== RUN   TestAcceptanceForNamespaceDataSource
TMC resources applied to the cluster successfully
 data_source_namespace_test.go:53: namespace data source acceptance test complete!
--- PASS: TestAcceptanceForNamespaceDataSource (301.15s)
.......
TMC resources applied to the cluster successfully
 resource_namepace_test.go:49: namespace resource acceptance test complete!
--- PASS: TestAcceptanceForNamespaceResource (279.15s)

Provider configuration has the wrong provider name as "tmc" instead of "tanzu-mission-control" causing the tests to fail. Modified the test to use the common provider testing code instead of the incorrect one.

Signed-off-by: Ramya Bangera <bangerar@vmware.com>
Copy link
Contributor

@shobha2626 shobha2626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramya-bangera ramya-bangera merged commit 7b21fe2 into main Feb 22, 2024
4 checks passed
@ramya-bangera ramya-bangera deleted the bangerar/fix-ns-test branch February 22, 2024 09:19
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants