-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Provisioner List Data read #379
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 25.39% 25.36% -0.04%
==========================================
Files 195 195
Lines 16788 16810 +22
==========================================
Hits 4264 4264
- Misses 12306 12328 +22
Partials 218 218 ☔ View full report in Codecov by Sentry. |
787e2c3
to
f78a402
Compare
Signed-off-by: Shobha M <mshobha@vmware.com>
f78a402
to
543c51f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update the datasource example to reflect this change and documentation update accordingly, which I don't see in this change.
- Run the datasource acceptance test and attach the screenshot
@shobha2626, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
3ee0da2
to
f20679c
Compare
Signed-off-by: Shobha M <mshobha@vmware.com>
f20679c
to
2edb61c
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What this PR does / why we need it: Fix Provisioner List Data read
Which issue(s) this PR fixes
Data source acceptance test
{
"version": 4,
"terraform_version": "1.6.4",
"serial": 2,
"lineage": "0b6f3483-1df4-bc67-fa8e-0263fed0b3f9",
"outputs": {},
"resources": [
{
"mode": "data",
"type": "tanzu-mission-control_provisioner",
"name": "read_provisioner",
"provider": "provider["vmware/devtest/tanzu-mission-control"]",
"instances": [
{
"schema_version": 0,
"attributes": {
"id": "prvn:01HP45HJY9NJTTRB69BH1PZ49S",
"provisioners": [
{
"management_cluster": "eks",
"meta": [],
"name": "demo-test",
"org_id": ""
}
]
},
"sensitive_attributes": []
}
]
}
],
"check_results": null
}
// LIST of Provisioners
"provisioners": [
{
"management_cluster": "eks",
"meta": [],
"name": "tf-test",
"org_id": ""
},
{
"management_cluster": "eks",
"meta": [],
"name": "tf-prv-test-2322938641799613315",
"org_id": ""
},
{
"management_cluster": "eks",
"meta": [],
"name": "tf-prv-test-9059343843537634380",
"org_id": ""
},
{
"management_cluster": "eks",
"meta": [],
"name": "tf-prv-test-2312083577691511843",
"org_id": ""
},
Additional information
Special notes for your reviewer