Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Provisioner List Data read #379

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

shobha2626
Copy link
Contributor

@shobha2626 shobha2626 commented Feb 13, 2024

  1. What this PR does / why we need it: Fix Provisioner List Data read

  2. Which issue(s) this PR fixes

Data source acceptance test

image

{
"version": 4,
"terraform_version": "1.6.4",
"serial": 2,
"lineage": "0b6f3483-1df4-bc67-fa8e-0263fed0b3f9",
"outputs": {},
"resources": [
{
"mode": "data",
"type": "tanzu-mission-control_provisioner",
"name": "read_provisioner",
"provider": "provider["vmware/devtest/tanzu-mission-control"]",
"instances": [
{
"schema_version": 0,
"attributes": {
"id": "prvn:01HP45HJY9NJTTRB69BH1PZ49S",
"provisioners": [
{
"management_cluster": "eks",
"meta": [],
"name": "demo-test",
"org_id": ""
}
]
},
"sensitive_attributes": []
}
]
}
],
"check_results": null
}

// LIST of Provisioners

"provisioners": [
{
"management_cluster": "eks",
"meta": [],
"name": "tf-test",
"org_id": ""
},
{
"management_cluster": "eks",
"meta": [],
"name": "tf-prv-test-2322938641799613315",
"org_id": ""
},
{
"management_cluster": "eks",
"meta": [],
"name": "tf-prv-test-9059343843537634380",
"org_id": ""
},
{
"management_cluster": "eks",
"meta": [],
"name": "tf-prv-test-2312083577691511843",
"org_id": ""
},

  1. Additional information

  2. Special notes for your reviewer

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (95cef99) 25.39% compared to head (2edb61c) 25.36%.

Files Patch % Lines
...l/resources/provisioner/data_source_provisioner.go 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   25.39%   25.36%   -0.04%     
==========================================
  Files         195      195              
  Lines       16788    16810      +22     
==========================================
  Hits         4264     4264              
- Misses      12306    12328      +22     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shobha2626 shobha2626 force-pushed the mshobha/fix-provisioner-list branch from 787e2c3 to f78a402 Compare February 13, 2024 11:01
Signed-off-by: Shobha M <mshobha@vmware.com>
@shobha2626 shobha2626 force-pushed the mshobha/fix-provisioner-list branch from f78a402 to 543c51f Compare February 14, 2024 05:32
Copy link
Contributor

@ramya-bangera ramya-bangera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Update the datasource example to reflect this change and documentation update accordingly, which I don't see in this change.
  2. Run the datasource acceptance test and attach the screenshot

@vmwclabot
Copy link
Member

@shobha2626, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Feb 14, 2024
@shobha2626 shobha2626 force-pushed the mshobha/fix-provisioner-list branch from 3ee0da2 to f20679c Compare February 14, 2024 07:24
@vmwclabot vmwclabot removed the dco-required DCO Required label Feb 14, 2024
Signed-off-by: Shobha M <mshobha@vmware.com>
@shobha2626 shobha2626 force-pushed the mshobha/fix-provisioner-list branch from f20679c to 2edb61c Compare February 14, 2024 07:39
@shobha2626 shobha2626 merged commit aa47e00 into main Feb 14, 2024
4 checks passed
@tenthirtyam tenthirtyam deleted the mshobha/fix-provisioner-list branch November 13, 2024 06:30
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants