Update the doc link and add the example link to the cutom policy guide #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 25.40% 25.39% -0.01%
==========================================
Files 195 195
Lines 16784 16788 +4
==========================================
Hits 4264 4264
- Misses 12302 12306 +4
Partials 218 218 ☔ View full report in Codecov by Sentry. |
vmw-vjn
reviewed
Feb 6, 2024
ramya-bangera
force-pushed
the
bangerar/custom-policy-guide-fix
branch
from
b2e1a59 to
13b55f9
Compare
…e creation and assignment in the policy guide Signed-off-by: Ramya Bangera <bangerar@vmware.com>
ramya-bangera
force-pushed
the
bangerar/custom-policy-guide-fix
branch
from
13b55f9 to
abea42c
Compare
…in the custom policy assignment is not found Initially this check was added as the custom template creation via TMC TF provider was not supported. Now since the provider supports creation of the custom template removing this check, to let user create the custom template and assign it to custom policy on the fly. Signed-off-by: Ramya Bangera <bangerar@vmware.com>
ramya-bangera
force-pushed
the
bangerar/custom-policy-guide-fix
branch
from
4c9b895 to
7df2dcd
Compare
vmw-vjn
approved these changes
Feb 13, 2024
|
Overall LGTM, hope the doc changes are tested using the tool for doc preview |
shobha2626
approved these changes
Feb 13, 2024
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Initially this check was added as the custom template creation via TMC TF provider was not supported. Now since the provider supports creation of the custom template removing this check,
to let user create the custom template and assign it to custom policy on the fly.
Which issue(s) this PR fixes
Additional information
Special notes for your reviewer