Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dataprotection clustergroup #375

Merged
merged 16 commits into from
Jan 31, 2024
Merged

Conversation

eastaga
Copy link

@eastaga eastaga commented Jan 22, 2024

  1. What this PR does / why we need it:
    CG Data Protection and Backup Schedule

  2. Which issue(s) this PR fixes

     (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):
    
     Fixes #
    
  3. Additional information

  4. Special notes for your reviewer

@vmwclabot
Copy link
Member

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Jan 22, 2024
@vmwclabot
Copy link
Member

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@eastaga
Copy link
Author

eastaga commented Jan 22, 2024

image image image image image

rnarenpujari
rnarenpujari previously approved these changes Jan 22, 2024
Copy link
Contributor

@rnarenpujari rnarenpujari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed through since we already reviewed the individual MRs.
The commit history is a bit messed up - can we clean that up a bit or enable squashing when you merge?

ramya-bangera
ramya-bangera previously approved these changes Jan 30, 2024
rnarenpujari and others added 16 commits January 30, 2024 16:29
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: Astha Agarwal <asagarwal@vmware.com>
Signed-off-by: Astha Agarwal <asagarwal@vmware.com>
Signed-off-by: Astha Agarwal <asagarwal@vmware.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: rnarenpujari <rnarenpujari@gmail.com>
Signed-off-by: Astha Agarwal  <asagarwal@vmware.com>
@eastaga eastaga dismissed stale reviews from ramya-bangera and rnarenpujari via 312af6e January 30, 2024 11:27
@eastaga eastaga force-pushed the feat/dataprotection-clustergroup branch from e0ee294 to 312af6e Compare January 30, 2024 11:27
@vmwclabot vmwclabot removed the dco-required DCO Required label Jan 30, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (88ddf24) 25.29% compared to head (312af6e) 25.40%.

Files Patch % Lines
internal/resources/backupschedule/scope/scope.go 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   25.29%   25.40%   +0.10%     
==========================================
  Files         192      195       +3     
  Lines       16722    16784      +62     
==========================================
+ Hits         4230     4264      +34     
- Misses      12274    12302      +28     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramya-bangera
Copy link
Contributor

Just glanced through the PR assuming it is end to end validated in the feature branch before seeking merge to main.

@eastaga eastaga merged commit b4c3cb5 into main Jan 31, 2024
4 checks passed
@tenthirtyam tenthirtyam deleted the feat/dataprotection-clustergroup branch November 13, 2024 06:30
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants