Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NPE issue in provisioner resource/datasource #373

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ramya-bangera
Copy link
Contributor

  1. What this PR does / why we need it:
    Added the fix to return without trying to parse the nil response in case of any error.

  2. Which issue(s) this PR fixes
    Internal Jira

  3. Additional information

  4. Special notes for your reviewer

Screenshot 2024-01-19 at 12 10 31 PM
<testsuite name="github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/provisioner" tests="2" failures="0" errors="0" id="230" hostname="sc2-10-187-102-46.nimbus.eng.vmware.com" time="45.050" timestamp="2024-01-19T07:26:16Z">
		<properties>
			<property name="coverage.statements.pct" value="62.80"></property>
		</properties>
		<testcase name="TestAcceptanceForProvisionerDataSource" classname="github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/provisioner" time="15.960">
			<system-out><![CDATA[    provisioner_data_source_test.go:43: provisioner datasource acceptance test complete!]]></system-out>
		</testcase>
		<testcase name="TestAcceptanceForProvisionerResource" classname="github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/provisioner" time="29.080">
			<system-out><![CDATA[    provisioner_resource_test.go:86: provisioner resource acceptance test complete!]]></system-out>
		</testcase>
	</testsuite>

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ee9e28b) 25.31% compared to head (25c9eca) 25.29%.

Files Patch % Lines
...l/resources/provisioner/data_source_provisioner.go 0.00% 2 Missing ⚠️
...rnal/resources/provisioner/resource_provisioner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   25.31%   25.29%   -0.03%     
==========================================
  Files         192      192              
  Lines       16665    16668       +3     
==========================================
- Hits         4219     4216       -3     
- Misses      12229    12234       +5     
- Partials      217      218       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shobha2626
shobha2626 previously approved these changes Jan 19, 2024
@ramya-bangera ramya-bangera dismissed shobha2626’s stale review January 19, 2024 10:35

The merge-base changed after approval.

Added the fix to return without trying to parse the nil response in case of any error.

Signed-off-by: Ramya Bangera <bangerar@vmware.com>
@ramya-bangera ramya-bangera merged commit 4dfb7a3 into main Jan 19, 2024
4 checks passed
@ramya-bangera ramya-bangera deleted the bangerar/fix-npe branch January 19, 2024 11:18
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants