Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait time for create/update operation to complete. #372

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ramya-bangera
Copy link
Contributor

  1. What this PR does / why we need it:
    Adding a wait time of 10sec after the create/update operation as the operation takes some time to complete and there is no status field to rely on to check the completion of create/update operation.

  2. Which issue(s) this PR fixes
    Issue tracked in internal jira

  3. Additional information

  4. Special notes for your reviewer

Screenshot 2024-01-19 at 12 10 31 PM

Test logs from automation:

Signed-off-by: Ramya Bangera <bangerar@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d6c5fee) 25.30% compared to head (e782184) 25.29%.

Files Patch % Lines
...rnal/resources/provisioner/resource_provisioner.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   25.30%   25.29%   -0.01%     
==========================================
  Files         192      192              
  Lines       16658    16664       +6     
==========================================
  Hits         4215     4215              
- Misses      12225    12231       +6     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramya-bangera ramya-bangera merged commit ee9e28b into main Jan 19, 2024
4 checks passed
@ramya-bangera ramya-bangera deleted the bangerar/add-wait-time branch January 19, 2024 10:36
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants