Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance test and guide for custom policy resource #371

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

shobha2626
Copy link
Contributor

  1. What this PR does / why we need it: Add acceptance test and guide for custom policy resource

image

GilTeraSky and others added 2 commits January 16, 2024 22:18
Signed-off-by: GilTS <gil@terasky.com>
Signed-off-by: Shobha M <mshobha@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (d0d6414) 25.25% compared to head (da0f966) 25.29%.

Files Patch % Lines
...ces/policy/kind/custom/recipe/tmc_custom_schema.go 41.05% 56 Missing ⚠️
...ernal/resources/policy/kind/custom/input_schema.go 0.00% 31 Missing ⚠️
...ternal/resources/policy/kind/custom/spec_schema.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   25.25%   25.29%   +0.04%     
==========================================
  Files         191      192       +1     
  Lines       16532    16657     +125     
==========================================
+ Hits         4175     4214      +39     
- Misses      12139    12225      +86     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shobha2626 shobha2626 merged commit 50bbbf8 into main Jan 17, 2024
4 checks passed
@tenthirtyam tenthirtyam deleted the mshobha/acc-test-custom-policy-assignment branch November 13, 2024 06:30
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants