-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Permission Template -- Feature Complete #342
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 25.29% 25.30%
=======================================
Files 192 192
Lines 16657 16659 +2
=======================================
+ Hits 4214 4216 +2
Misses 12225 12225
Partials 218 218 ☔ View full report in Codecov by Sentry. |
internal/resources/permissiontemplate/tests/datasource_tf_configs.go
Outdated
Show resolved
Hide resolved
@vmw-vjn having a guide section for permission template would be helpful? |
Please squash the commits accordingly |
I included the entire Terraform config that utilizes the permission template, from my understanding a guide is needed when you need to create assets manually. |
c9a0ab0
to
ab77f83
Compare
ec13063
to
2b3216d
Compare
@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
2b3216d
to
f7eea48
Compare
@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
f7eea48
to
f4df2ea
Compare
@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f4df2ea
to
e9e3212
Compare
@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
e9e3212
to
b013f33
Compare
@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
b013f33
to
32d3ba1
Compare
@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
32d3ba1
to
cd8f94d
Compare
@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
internal/client/permissiontemplate/permission_template_resource.go
Outdated
Show resolved
Hide resolved
cd8f94d
to
03d7e88
Compare
@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What this PR does / why we need it:
This PR includes the complete implementation of a Permission Template.
Which issue(s) this PR fixes
Additional information
It was decided to go with a data source because there is no real state for a permission template as it can be generated for a
non-existing credentials.
The following issues were addressed as follows:
a. When generating a permission template for EKS, the templateValue field might contains values which are not defined as
parameters in the CloudFormation template. The workaround which was applied is to decode the template, and remove the
undefined values. This values are being kept instead in another computed field "undefined_template_values".
b. The CloudFormation template returned from the API defined only a "Message" field as output and which contains text and
the ARN. The workaround should be implemented in the Terraform code to split the message data and get the ARN only.
Special notes for your reviewer