Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Permission Template -- Feature Complete #342

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

GilTeraSky
Copy link
Contributor

  1. What this PR does / why we need it:
    This PR includes the complete implementation of a Permission Template.

  2. Which issue(s) this PR fixes

  3. Additional information
    It was decided to go with a data source because there is no real state for a permission template as it can be generated for a
    non-existing credentials.

    The following issues were addressed as follows:
    a. When generating a permission template for EKS, the templateValue field might contains values which are not defined as
    parameters in the CloudFormation template. The workaround which was applied is to decode the template, and remove the
    undefined values. This values are being kept instead in another computed field "undefined_template_values".
    b. The CloudFormation template returned from the API defined only a "Message" field as output and which contains text and
    the ARN. The workaround should be implemented in the Terraform code to split the message data and get the ARN only.

  4. Special notes for your reviewer

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50bbbf8) 25.29% compared to head (03d7e88) 25.30%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   25.29%   25.30%           
=======================================
  Files         192      192           
  Lines       16657    16659    +2     
=======================================
+ Hits         4214     4216    +2     
  Misses      12225    12225           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shobha2626
Copy link
Contributor

@vmw-vjn having a guide section for permission template would be helpful?

@shobha2626
Copy link
Contributor

Please squash the commits accordingly

@GilTeraSky
Copy link
Contributor Author

@vmw-vjn having a guide section for permission template would be helpful?

I included the entire Terraform config that utilizes the permission template, from my understanding a guide is needed when you need to create assets manually.
In this case it is very simple, you have a data source with certain fields to be used in another resource, therefore it is very straight forwards to implement, especially when you can see the entire Terraform.

@GilTeraSky GilTeraSky force-pushed the feat/permission-template branch from c9a0ab0 to ab77f83 Compare November 21, 2023 08:59
vrabbi
vrabbi previously approved these changes Nov 21, 2023
@vmwclabot
Copy link
Member

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Jan 8, 2024
@ankitsny ankitsny force-pushed the feat/permission-template branch from 2b3216d to f7eea48 Compare January 10, 2024 06:35
@vmwclabot
Copy link
Member

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@ankitsny ankitsny force-pushed the feat/permission-template branch from f7eea48 to f4df2ea Compare January 10, 2024 06:44
@vmwclabot
Copy link
Member

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

shobha2626
shobha2626 previously approved these changes Jan 11, 2024
Copy link
Contributor

@shobha2626 shobha2626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmwclabot
Copy link
Member

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@ankitsny ankitsny force-pushed the feat/permission-template branch from e9e3212 to b013f33 Compare January 18, 2024 07:40
@vmwclabot
Copy link
Member

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@ankitsny ankitsny force-pushed the feat/permission-template branch from b013f33 to 32d3ba1 Compare January 18, 2024 09:02
@vmwclabot
Copy link
Member

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@ankitsny ankitsny force-pushed the feat/permission-template branch from 32d3ba1 to cd8f94d Compare January 18, 2024 09:18
@vmwclabot
Copy link
Member

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@ankitsny ankitsny force-pushed the feat/permission-template branch from cd8f94d to 03d7e88 Compare January 18, 2024 09:59
@vmwclabot
Copy link
Member

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@ankitsny ankitsny requested a review from shobha2626 January 19, 2024 06:43
@ankitsny ankitsny merged commit c483524 into main Jan 19, 2024
4 checks passed
@tenthirtyam tenthirtyam deleted the feat/permission-template branch November 13, 2024 06:30
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-required DCO Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants