[Feature complete]Custom IAM Role models, client, schema, implementation and docs #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 25.29% 25.30%
=======================================
Files 192 192
Lines 16657 16658 +1
=======================================
+ Hits 4214 4215 +1
Misses 12225 12225
Partials 218 218 ☔ View full report in Codecov by Sentry. |
iprathapan
approved these changes
Nov 16, 2023
vrabbi
previously approved these changes
Nov 20, 2023
GilTeraSky
force-pushed
the
feat/custom-role
branch
from
09b254d to
7dfd6ab
Compare
iprathapan
approved these changes
Nov 30, 2023
ramya-bangera
force-pushed
the
feat/custom-role
branch
from
7dfd6ab to
6f4dc78
Compare
ramya-bangera
changed the title
ramya-bangera
force-pushed
the
feat/custom-role
branch
from
6f4dc78 to
af84f5d
Compare
|
Thanks for attaching the screenshot, is all the CRUD operation tested? |
|
Overall. LGTM |
Yes |
…tion and docs Signed-off-by: GilTS <gil@terasky.com>
Signed-off-by: Ramya Bangera <bangerar@vmware.com>
…chema Signed-off-by: Ramya Bangera <bangerar@vmware.com>
ramya-bangera
force-pushed
the
feat/custom-role
branch
from
af84f5d to
e83bed2
Compare
shobha2626
approved these changes
Jan 17, 2024
ankitsny
approved these changes
Jan 18, 2024
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR includes the complete implementation of a Custom IAM Role.
Which issue(s) this PR fixes
Additional information
Acceptance test log:
bangerar@bangerarYMD6M tests % go test -v -tags=customiamrole === RUN TestAcceptanceCustomIAMRoleResource custom_iam_role_test.go:72: Custom IAM role resource acceptance test complete! --- PASS: TestAcceptanceCustomIAMRoleResource (19.49s) PASS ok github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/customiamrole/tests 20.055sExample custom role:
