Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for Self provisioned AWS S3 or S3-compatible storage credential creation #296

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

ramya-bangera
Copy link
Contributor

  1. What this PR does / why we need it:
    Add example for Self provisioned AWS S3 or S3-compatible storage credential creation

  2. Which issue(s) this PR fixes

    Internal Jira ticket
    
  3. Additional information
    This change adds example for creatingSelf provisioned AWS S3 or S3-compatible storage credential creation for data protection

  4. Special notes for your reviewer

…rage credential for data protection

Signed-off-by: Ramya Bangera <bangerar@vmware.com>
ankitsny
ankitsny previously approved these changes Oct 19, 2023
@vmwclabot
Copy link
Member

@ramya-bangera, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Oct 20, 2023
Signed-off-by: Ramya Bangera <bangerar@vmware.com>
@ramya-bangera ramya-bangera force-pushed the bangerar/add-self-provisioned-aws-example branch from 68b7195 to 6155167 Compare October 20, 2023 06:34
@vmwclabot vmwclabot removed the dco-required DCO Required label Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b8edbd) 25.39% compared to head (8d2244a) 26.12%.
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   25.39%   26.12%   +0.72%     
==========================================
  Files         155      161       +6     
  Lines       13591    14318     +727     
==========================================
+ Hits         3452     3740     +288     
- Misses       9982    10411     +429     
- Partials      157      167      +10     

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ramya Bangera <bangerar@vmware.com>
Copy link
Contributor

@shobha2626 shobha2626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramya-bangera ramya-bangera merged commit bc2a10e into main Oct 20, 2023
@ramya-bangera ramya-bangera deleted the bangerar/add-self-provisioned-aws-example branch October 20, 2023 07:18
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants