Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refining the documentation #14

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Refining the documentation #14

merged 3 commits into from
Jan 4, 2022

Conversation

Vasundharashukla
Copy link
Contributor

@Vasundharashukla Vasundharashukla commented Nov 12, 2021 •
edited
Loading

Added Guides for Nodepool and Workload cluster entries, templates for all resources.
Acceptance test section has been added to Makefile and README has been updated with Testing section.

shobha2626
shobha2626 suggested changes Nov 15, 2021
View reviewed changes
@Vasundharashukla Vasundharashukla force-pushed the vasundharas/templating branch 4 times, most recently from 44025f1 to 7662b23 Compare November 18, 2021 12:37
@shobha2626
Copy link
Contributor

Try to split the commit (descriptively) before and after doc generation. It would help In reviewing.

@shobha2626
Copy link
Contributor

Please add template for node pool as well

@vmwclabot
Copy link
Member

@Vasundharashukla, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 17, 2021
@vmwclabot
Copy link
Member

@Vasundharashukla, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot removed the dco-required DCO Required label Dec 17, 2021
@Vasundharashukla Vasundharashukla marked this pull request as draft December 17, 2021 08:41
@Vasundharashukla Vasundharashukla self-assigned this Dec 17, 2021
@vmwclabot
Copy link
Member

@Vasundharashukla, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 20, 2021
@vmwclabot
Copy link
Member

@Vasundharashukla, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@Vasundharashukla, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Vasundharashukla Vasundharashukla marked this pull request as ready for review December 20, 2021 20:21
@vmwclabot
Copy link
Member

@Vasundharashukla, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@Vasundharashukla, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot removed the dco-required DCO Required label Dec 21, 2021
@Vasundharashukla
Templates and example files added
e0304c6 
Splitting cluster examples and adding templates for doc generation

Signed-off-by: Vasundhara Shukla <vasundharas@vmware.com>
@Vasundharashukla
Generated documents
9155cd8 
documents generated via Terraform plugin

Signed-off-by: Vasundhara Shukla <vasundharas@vmware.com>
@Vasundharashukla
README, MAKE file updated along with copyright information
2628448 
Updating the README and adding Acceptance test section to MAKE

Signed-off-by: Vasundhara Shukla <vasundharas@vmware.com>
@shobha2626
Copy link
Contributor

docs/guides only for TKGs/TKGm cluster and node pool?

@shobha2626
Copy link
Contributor

docs/guides are only for TKGs/TKGm workload cluster and node pool resources because they require certain prerequisites to be done like TKGs/TKGm workload cluster would require attached healthy management cluster and nodepool would require healthy TKGs/TKGm workload cluster in turn.

shobha2626
shobha2626 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@shobha2626 shobha2626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shobha2626 shobha2626 merged commit e7ebd61 into main Jan 4, 2022
@Vasundharashukla Vasundharashukla deleted the vasundharas/templating branch January 19, 2022 05:27
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shobha2626 shobha2626 shobha2626 approved these changes

Assignees

@Vasundharashukla Vasundharashukla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vasundharashukla @shobha2626 @vmwclabot