Skip to content

Commit

Permalink
Fix ExternalLinkBlock (#2106)
Browse files Browse the repository at this point in the history
In #2102 I missed that the url can be undefined because it has an any
type and the typing of validateUrl was also incorrect. Now the
`ExternalLinkBlock` breaks when the URL is emptied. This PR fixes that
by checking if url is defined.
  • Loading branch information
thomasdax98 authored May 23, 2024
1 parent 815ba51 commit 984ebc9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { FormattedMessage } from "react-intl";

import { isLinkTarget } from "./isLinkTarget";

export function validateLinkTarget(linkTarget: string) {
if (!isLinkTarget(linkTarget)) {
export function validateLinkTarget(linkTarget?: string) {
if (linkTarget && !isLinkTarget(linkTarget)) {
return <FormattedMessage id="comet.validation.validateLinkTarget.invalid" defaultMessage="Invalid link target" />;
}
}
2 changes: 1 addition & 1 deletion packages/admin/cms-admin/src/validation/validateUrl.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { isURL } from "class-validator";
import React from "react";
import { FormattedMessage } from "react-intl";

export function validateUrl(url: string) {
export function validateUrl(url?: string) {
if (url && !isURL(url)) {
return <FormattedMessage id="comet.validation.validateUrl.invalid" defaultMessage="Invalid URL" />;
}
Expand Down

0 comments on commit 984ebc9

Please sign in to comment.