Add script to upgrade to ESLint v9 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently the update script fails after executing the before-install stage, when the upgrade tries to eslint files. I think we have to upgrade eslint to v9 in this repo as well, before this can work. |
So maybe we should merge this only before releasing Comet 8 stable? |
johnnyomair
reviewed
Jan 30, 2025
| }); | ||
| deleteOldEslintRc({ workingDirectory: "api/" }); | ||
| } | ||
| if (existsSync("site/package.json")) { |
There was a problem hiding this comment.
There are projects that have multiple sites (e.g., sites/site-a, sites/site-b). Should we change this script to check for all package.json files?
There was a problem hiding this comment.
we can try to do this.
johnnyomair
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an update script that: