Check for valid sender defensively

vivid-planet · Jun 10, 2024 · ddf4b20 · ddf4b20
1 parent 78c1924
commit ddf4b20
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/api/src/brevo-config/brevo-config.resolver.ts b/packages/api/src/brevo-config/brevo-config.resolver.ts
@@ -30,11 +30,11 @@ export function createBrevoConfigResolver({
         private async validateSender({ email, name }: { email: string; name: string }): Promise<boolean> {
             const senders = await this.brevoSenderApiService.getSenders();
 
-            if (!senders || !senders.some((sender) => sender.email === email && sender.name === name)) {
-                return false;
+            if (senders && senders.some((sender) => sender.email === email && sender.name === name)) {
+                return true;
             }
 
-            return true;
+            return false;
         }
 
         @RequiredPermission(["brevo-newsletter-config"], { skipScopeCheck: true })