Merge pull request #31 from vivid-planet/do-not-allow-edit-of-main-ta…

…rget-group COM-271: Do not allow edit of main target group
vivid-planet · Jan 30, 2024 · 1a7ba40 · 1a7ba40
2 parents 4339960 + 9799fd9
commit 1a7ba40
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/packages/admin/src/targetGroups/TargetGroupsGrid.tsx b/packages/admin/src/targetGroups/TargetGroupsGrid.tsx
@@ -38,6 +38,7 @@ const targetGroupsFragment = gql`
         title
         totalSubscribers
         totalContactsBlocked
+        isMainList
     }
 `;
 
@@ -123,15 +124,15 @@ export function TargetGroupsGrid({ scope }: { scope: ContentScopeInterface }): R
             sortable: false,
             filterable: false,
             type: "actions",
-            renderCell: (params) => {
+            renderCell: ({ row }) => {
+                if (row.isMainList) return;
                 return (
                     <>
-                        <IconButton component={StackLink} pageName="edit" payload={params.row.id}>
+                        <IconButton component={StackLink} pageName="edit" payload={row.id}>
                             <Edit color="primary" />
                         </IconButton>
                         <CrudContextMenu
                             copyData={() => {
-                                const row = params.row;
                                 return {
                                     title: row.title,
                                 };
@@ -145,7 +146,7 @@ export function TargetGroupsGrid({ scope }: { scope: ContentScopeInterface }): R
                             onDelete={async () => {
                                 await client.mutate<GQLDeleteTargetGroupMutation, GQLDeleteTargetGroupMutationVariables>({
                                     mutation: deleteTargetGroupMutation,
-                                    variables: { id: params.row.id },
+                                    variables: { id: row.id },
                                 });
                             }}
                             refetchQueries={[targetGroupsQuery]}

diff --git a/packages/api/src/target-group/target-group.resolver.ts b/packages/api/src/target-group/target-group.resolver.ts
@@ -108,6 +108,10 @@ export function createTargetGroupsResolver({
         ): Promise<TargetGroupInterface> {
             const targetGroup = await this.repository.findOneOrFail(id);
 
+            if (targetGroup.isMainList) {
+                throw new Error("Cannot edit a main target group");
+            }
+
             if (lastUpdatedAt) {
                 validateNotModified(targetGroup, lastUpdatedAt);
             }
@@ -135,6 +139,10 @@ export function createTargetGroupsResolver({
         async deleteTargetGroup(@Args("id", { type: () => ID }) id: string): Promise<boolean> {
             const targetGroup = await this.repository.findOneOrFail(id);
 
+            if (targetGroup.isMainList) {
+                throw new Error("Cannot delete a main target group");
+            }
+
             const isDeletedInBrevo = await this.brevoApiContactsService.deleteBrevoContactList(targetGroup.brevoId);
 
             if (!isDeletedInBrevo) {