Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup Experimental Conditions #5

Closed
wants to merge 8 commits into from

Conversation

AbrarNad
Copy link
Member

@AbrarNad AbrarNad commented Oct 29, 2024

Give a longer description of what this PR addresses and why it's needed

This PR introduces 3 experimental conditions.

  1. control
  2. salient
  3. annotation

Provide pictures/videos of the behavior before and after these changes (optional)

Designs - https://docs.google.com/presentation/d/1m8gOz9_7Kv2NsV6xhGEkemYXN3Dt5KeipxSRahqdoLs/edit?usp=sharing

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

QA steps:

  • Experimental conditions are working as expected.

@AbrarNad AbrarNad requested a review from mlisnic October 29, 2024 20:15
@AbrarNad AbrarNad closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant