Feat/enable backfill #215
Feat/enable backfill #215
Conversation
Davidson-Souza
force-pushed
the
feat/enable-backfill
branch
from
9082167 to
bc7878c
Compare
Davidson-Souza
force-pushed
the
feat/enable-backfill
branch
from
fb4a0e0 to
875e086
Compare
Davidson-Souza
force-pushed
the
feat/enable-backfill
branch
2 times, most recently
from
7360daf to
b2f7df0
Compare
Davidson-Souza
force-pushed
the
feat/enable-backfill
branch
from
b2f7df0 to
b1a3336
Compare
|
Is this ready to merge ? |
|
I don't remember the state of this 😆 . I'll rebase and see if it still works |
Davidson-Souza
force-pushed
the
feat/enable-backfill
branch
from
b1a3336 to
68efee7
Compare
|
@jaoleal pushed a rebase. The tests are green, but I haven't tried to run yet |
|
I am reviewing it rn, it seems to me to be working, however it has not finished the idb yet. Is there a specific reason why it hasn't been merged yet? |
|
For the review, the only problem I encountered when using the backfill up to now (except for the bugs that will be fixed on rebase) is on checking the status of the backfill. I believe there should be an easy way to check the progress even while running on daemon. Maybe a follow-up PR? |
Davidson-Souza
force-pushed
the
feat/enable-backfill
branch
from
68efee7 to
1d28cee
Compare
This is a very good observation. I do think a follow-up would be better, this is already huge on its own. |
Davidson-Souza
force-pushed
the
feat/enable-backfill
branch
from
1d28cee to
7183d21
Compare
|
Force-pushed 7183d21 fixing a small bug with recovery |
There was a problem hiding this comment.
The flags on read me must be updated to match the actual call on florestad.
Also, there are a couple warnings on clippy, so as #386 is on the way, I believe the warnings could also be handled before merging. After fixing these two observations, ACK.
Davidson-Souza
force-pushed
the
feat/enable-backfill
branch
from
7183d21 to
8875414
Compare
No description provided.