-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Excel format support (#156) #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Excel format support added * fix issuses * Update README.md * Update README.md * Update README.md * Update README.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3-dev #162 +/- ##
=======================================
Coverage 81.79% 81.79%
=======================================
Files 20 21 +1
Lines 692 780 +88
=======================================
+ Hits 566 638 +72
- Misses 79 84 +5
- Partials 47 58 +11 ☔ View full report in Codecov by Sentry. |
vdjagilev
added a commit
that referenced
this pull request
Jun 2, 2024
* Add Excel format support (#156) * Excel format support added * fix issuses * Update README.md * Update README.md * Update README.md * Update README.md * tweak: ci: fix branch trigger name * tweak: err check * chore: refactor writing headers * chore: minor warning fixes * chore: ci: update versions * refactor: split into smaller functions * tweak: excel: column width * tweak: excel: cosmetic text wrapping * tweak: excel: ip-addr & hostname text cosmetic improvements * tests: implement basic unit tests * tweak: linter fixes * tests: increase validation coverage * tests: coverage: output file * tests: excel: more test cases * tests: excel: bigger coverage --------- Co-authored-by: Gorka <72318822+gorkavp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/medium
Medium priority issue
tech/excel
tech/go
Golang
type/feature
New feature (or request)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.