Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Excel format support (#156) #162

Merged
merged 16 commits into from
Feb 23, 2024
Merged

Add Excel format support (#156) #162

merged 16 commits into from
Feb 23, 2024

Conversation

vdjagilev
Copy link
Owner

No description provided.

* Excel format support added

* fix issuses

* Update README.md

* Update README.md

* Update README.md

* Update README.md
@vdjagilev vdjagilev added priority/medium Medium priority issue tech/go Golang type/feature New feature (or request) tech/excel labels Feb 11, 2024
@vdjagilev vdjagilev self-assigned this Feb 11, 2024
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 81.79%. Comparing base (1c26b70) to head (2da6952).
Report is 1 commits behind head on v3-dev.

Files Patch % Lines
formatter/formatter_excel.go 71.76% 13 Missing and 11 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           v3-dev     #162   +/-   ##
=======================================
  Coverage   81.79%   81.79%           
=======================================
  Files          20       21    +1     
  Lines         692      780   +88     
=======================================
+ Hits          566      638   +72     
- Misses         79       84    +5     
- Partials       47       58   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vdjagilev vdjagilev merged commit 2972f76 into v3-dev Feb 23, 2024
8 of 9 checks passed
@vdjagilev vdjagilev deleted the feat/excel-support branch February 23, 2024 18:51
vdjagilev added a commit that referenced this pull request Jun 2, 2024
* Add Excel format support (#156)

* Excel format support added

* fix issuses

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* tweak: ci: fix branch trigger name

* tweak: err check

* chore: refactor writing headers

* chore: minor warning fixes

* chore: ci: update versions

* refactor: split into smaller functions

* tweak: excel: column width

* tweak: excel: cosmetic text wrapping

* tweak: excel: ip-addr & hostname text cosmetic improvements

* tests: implement basic unit tests

* tweak: linter fixes

* tests: increase validation coverage

* tests: coverage: output file

* tests: excel: more test cases

* tests: excel: bigger coverage

---------

Co-authored-by: Gorka <72318822+gorkavp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium Medium priority issue tech/excel tech/go Golang type/feature New feature (or request)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants