Adding Support for IterableDataset in "standardize_data_formats" #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for IterableDataset in the function "standardize_data_formats", similar to the previous PR: #98
Changes
Instead of slicing the dataset using indexes, uses
itertools.isliceBug Details
Current code tries to slice the dataset with indexes, which is not possible for an IterableDataset, also tries to pass num_proc which is unsupported by the IterableDataset (as of now).
Solution
Use
itertools.islicethe dataset and avoid passing num_proc for IterableDataset