Allow access to manage gcp log views #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhotan
changed the title
ctxswitch
reviewed
Jan 22, 2025
| - logging.views.listLogs | ||
| - logging.views.listResourceKeys | ||
| - logging.views.listResourceValues | ||
| - logging.views.setIamPolicy |
There was a problem hiding this comment.
Is setting and updating required for what we need?
There was a problem hiding this comment.
Should have looked at the other PR first ;). I see that it is. I think the question now is one around opt-in. The team had chatted before about potential issues with gaining carte-blanche access to logs. I'm curious if the approach would be to require the customer to apply those specific permissions (temporarily if needed) themselves or opt in to a more flexible set of permissions.
There was a problem hiding this comment.
Is setting and updating required for what we need?
Yes
Let's follow up offline
ctxswitch
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for Union to create Google Cloud logging views. Specifically focused on creating Uion accessible views for GKE auto-scaler and Managed instance group manager for scaling issues.
relates to PE-1569