-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filemanager crawl #859
Conversation
…rls aren't returned for archived data
…en determining `is_accessible`
…emanager-crawl # Conflicts: # lib/workload/stateless/stacks/filemanager/filemanager/src/database/entities/sea_orm_active_enums.rs # lib/workload/stateless/stacks/filemanager/filemanager/src/database/mod.rs # lib/workload/stateless/stacks/filemanager/filemanager/src/events/aws/collecter.rs # lib/workload/stateless/stacks/filemanager/filemanager/src/events/aws/mod.rs # lib/workload/stateless/stacks/filemanager/filemanager/src/handlers/aws.rs # lib/workload/stateless/stacks/filemanager/filemanager/src/queries/list.rs # lib/workload/stateless/stacks/filemanager/filemanager/src/queries/mod.rs # lib/workload/stateless/stacks/filemanager/filemanager/src/routes/filter/mod.rs # lib/workload/stateless/stacks/filemanager/filemanager/src/routes/openapi.rs
.. will review soon in arvo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Give it try RestApi if you really need to. Do watch out on cognito authorizer but this might work nowaday. Might hit and loose built-in JWT auth capability but, could workaround with Lambda Auth (but then ... umm, a bit less in favour as the overhead it adds, tbh). |
Closes #852
Changes
s3_crawl
table in the database.#[double]
usage, which was conflicting withaws-smithy-mocks-experimental
The async API isn't working yet because
HttpApi
doesn't support async lambda invocations. I'm happy with the PR for now and I'll add that in another PR.I can either change the API to a
RestApi
or re-invoke the Lambda function from within the existingHttpApi
endpoint and detach the execution. I'm not sure if there is a preference to useRestApi
with any of the other microservices?