Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOE-212 Infracost integration in pipeline #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ntse
Copy link
Contributor

@ntse ntse commented Nov 29, 2024

No description provided.

@ntse ntse force-pushed the feature/doe212-testing-infracost branch from 5aaf8b1 to 2662775 Compare November 29, 2024 14:41
Copy link

github-actions bot commented Nov 29, 2024

💰 Infracost report

Consider fixing these issues, they don't align with your company's FinOps policies & the Well-Architected Framework.

Tagging policies
🔴 FinOps tags

This example Tagging policy shows how you can enforce required FinOps tag keys/values in pull requests. This example checks for the tags 'Service' (can have any value) and 'Environment' (must be Dev/Stage/Prod) on all taggable resources being changed in the pull request. You can adjust it from https://dashboard.infracost.io > Governance > Tagging policies. You have a 14 day trial of this feature as it's part of Infracost Cloud.

resource aws_lb.this[0] provisioned by module module.alb

  • Missing mandatory tag Environment. Must be one of Dev, Stage, Prod. Consider using default tags to avoid adding tags to individual resources.
  • Missing mandatory tag: Service. Consider using default tags to avoid adding tags to individual resources.

in project ukhsa-collaboration/devops-github-reusable-workflows/applications/hello-world-front-prd

resource aws_ecs_service.this[0] provisioned by module module.ecs_service

  • Missing mandatory tag Environment. Must be one of Dev, Stage, Prod. Consider using default tags to avoid adding tags to individual resources.
  • Missing mandatory tag: Service. Consider using default tags to avoid adding tags to individual resources.
  • Dynamically created task resources will not have tag(s) Service, Environment because tag propagation is not configured. Tag propagation should be configured by setting propagate_tags to a valid value (TASK_DEFINITION, SERVICE)

in project ukhsa-collaboration/devops-github-reusable-workflows/applications/hello-world-front-prd

There are also 2 pre-existing issues in the main branch. Fix some to climb your org’s leaderboard 🥇

This comment will be updated when code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant