-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpld_gridgen - Update regression tests to run in parallel #1027
base: develop
Are you sure you want to change the base?
cpld_gridgen - Update regression tests to run in parallel #1027
Conversation
Add the remove of some log files from scripts. Fixes ufs-community#1016.
@DeniseWorthen - I would like you to review this. No hurry. The overall functionality is unchanged. |
I still have some final cleanup to do. |
Oh that's great! I'll take a look when I've got a chance. |
as this is not used in OPS. Fixes ufs-community#1016.
Besides the standard tests listed in the description, other tests were performed to ensure that all functionality is retained. Using 9c15d3a on Hercules, the executable directory was removed. When
|
Using 9c15d3a, when
|
way to run cpld_gridgen. Fixes ufs-community#1016.
DESCRIPTION OF CHANGES:
Currently, each regression test runs in sequence. These updates submit all tests to the batch queue at once, where they run independently. Then, when they are finished, a 'summary' job is triggered to create some final log files, check for errors and create a "summary" log. All other functions, such as options to build the executable (
rt.sh -b
), create a new baseline (rt.sh -c
) and test against the new baseline (rt.sh -m
) are retained.Some specifics:
check_results
function was moved fromrt.sh
to./ush/cpld_gridgen.sh
rt_summary.sh
is called fromrt.sh
. It checks for errors, concatenates the log files from the individual tests to a final log file, checks for errors and creates a summary file.exports
from the scripts.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
cpld_gridgen
consistency tests locally on all Tier 1 machines.cpld_gridgen
consistency tests using the-b
option on any Tier 1 machine to test the build executable option.cpld_gridgen
consistency tests using the-c
option on any Tier 1 machine to create a new baseline. Then run it again using the-m
option to compare against the new baseline.DEPENDENCIES:
None.
DOCUMENTATION:
All new and updated source code must be documented with Doxygen.
If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.
ISSUE:
Fixes #1016.